Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Float32 as type presented to Flux chains #276

Merged
merged 18 commits into from
Sep 29, 2024
Merged

Force Float32 as type presented to Flux chains #276

merged 18 commits into from
Sep 29, 2024

Conversation

ablaom
Copy link
Collaborator

@ablaom ablaom commented Sep 26, 2024

This PR replaces #272 and the fix #274, resolving #275.

@ablaom
Copy link
Collaborator Author

ablaom commented Sep 29, 2024

Thanks @EssamWisam, much appreciated.

I will merge this, but just note there is some noise in the test log because of some method redefinitions in test/entity_embedding.jl. They occur because of that loop you have over finalizer = [softmax, relu]. It's only bothering me because I'm likely to forget later what the source of the complaint is and waste time re-investigating. Be great if you could clean this up some time.

@ablaom ablaom merged commit 19d4275 into dev Sep 29, 2024
6 checks passed
@ablaom ablaom deleted the double-trouble branch September 29, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants