[17.0][MIG] rma #512
Merged
[17.0][MIG] rma #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
17.0-mig-rma-good
branch
8 times, most recently
from
a392951
to
297cef4
Compare
* fix assignment of moves. * default qty in rma lines. * remove account dependency. * test and flake8 fixes.
… supplier [IMP]Separate menus for customer and supplier operations * Add active field to rma operation * Added tests * Fix travis * Fix create supplier rma from customer rma
* rma: receipt_policy selections not matching. * rma_sale: fix _prepare_rma_line_from_sale_order_line.
* remove unneded copy attributes. * simplify action_view methods. * fix wrong naming. * fix misplaced views. * fix wrong count and view actions for rma.orders in invoices. * fix error when installing the module. * remove unneded data update when preparing rma lines from invoice lines. * minor extra fixes.
* remove unneded copy and ondelete attributes. * simplify action_view methods. * fix rma line supplier view. * fix wizard. * extend README. * minor extra fixes.
… rma.order is optional.
AaronHForgeFlow
force-pushed
the
17.0-mig-rma-good
branch
from
297cef4
to
cb5a8a1
Compare
qty_done -> quantity reserved_qty field does no exist anymore
AaronHForgeFlow
commented
May 6, 2024
When returning or delivering a serial product from a RMA, we will calculate by default its package. Later, it can be modyfied by the user.
… 'Customers' location
|
Includes also #492 |
|
Hi Aaron, can you also include #498 ? |
|
@DavidJForgeFlow done. thanks |
When looking at stock moves created from a rma group, it may be confusing knowing who's move is for which RMA line. This improvement should avoid these confusions.
AaronHForgeFlow
force-pushed
the
17.0-mig-rma-good
branch
from
0889ac7
to
8c16ce7
Compare
|
Also included #474 |
DavidJForgeFlow
approved these changes
Jul 9, 2024
|
I think this is ready to be merged. If some issues arises we can take care of them in future PRs. |
AaronHForgeFlow
force-pushed
the
17.0-mig-rma-good
branch
2 times, most recently
from
1f6a1bb
to
08d8f53
Compare
AaronHForgeFlow
force-pushed
the
17.0-mig-rma-good
branch
from
08d8f53
to
2ac6255
Compare
|
I think it is time to merge this, further corrections will be done in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of base rma module.
Supersedes #502
Reasons for supersede:
Sorry for the inconvenience.
@ForgeFlow