[17.0][MIG] rma #512

* fix assignment of moves. * default qty in rma lines. * remove account dependency. * test and flake8 fixes.

… supplier [IMP]Separate menus for customer and supplier operations * Add active field to rma operation * Added tests * Fix travis * Fix create supplier rma from customer rma

* rma: receipt_policy selections not matching. * rma_sale: fix _prepare_rma_line_from_sale_order_line.

* remove unneded copy attributes. * simplify action_view methods. * fix wrong naming. * fix misplaced views. * fix wrong count and view actions for rma.orders in invoices. * fix error when installing the module. * remove unneded data update when preparing rma lines from invoice lines. * minor extra fixes.

* remove unneded copy and ondelete attributes. * simplify action_view methods. * fix rma line supplier view. * fix wizard. * extend README. * minor extra fixes.

… rma.order is optional.

… reduction)

the rma module had company_id fields on rma.order and rma.order.line but not on rma.operation, and no global multicompany record rules. -> we fix this and avoid a mess with people allowed to see an operation in the drop down list but unable to use it because if points to a warehouse of another company

use the archive button in the form view, rather than a normal boolean field.

when working with odoobot account, you would get the wrong company_id on the RMA stock.rules of the warehouse on which you enabled RMA

…are not activated

[ENH]add term and conditions field to be printed and send to the partner [FIX]do not show rma groups on the rma line form view if they are not activated

…_supplier

Improve security

* [IMP] rma: Fill rma lines in tree

rma.line views, supplier view is an extension of customer one. This makes easier to edit common elements in both views and ease maintenance.

right in v14. Actions that read those records need to use `sudo` to allow non-admin users to be able to use these actions.

* remove also validation error when setting the rma to draft where there are done pickings

In the scenario where we use a 2 or 3 step receipts or pickings we want to make sure that we correctly count and classify the pickings.

…a groups - added restriction to approve rma with product tracking on serial, should be only one to receive

* remove code call to unexisting `force_asign`. * only one model per model file and rename as appropriate.

…sociation

… preparation

…rrect price unit in moves Otherwise the inventory accounting will be completely wrong.

[FIX] rma: rma_custmer_user has no write permissions in partner, so compute method fails. [IMP] rma: use rma user in tests [FIX] rma_account: move_line_id field string [IMP] rma, rma_account, rma_sale, rma_purchase: tests for stock valuation [FIX] account_move_line_rma_order_line: minor lint, make auto-install

Those are needed after making some fields company dependent

When creating pickings, ensure that the applied stock rule was taken from the operation's routes. Otherwise, the default procurement rules for a warehouse may kick in, creating incoming customer goods not from the customer location but from the resupply warehouse.

@florian-dacosta

Fixes #274 Thanks to @florian-dacosta for suggesting this approach.

Hide button and fields depending on the policy chosen on the rma line

- auto_confirm_rma_sale - free_of_charge_rma_sale

Otherwise the anglo saxon entries won't be correct. For example, the Interim (Delivered) account should balance after receiving and triggering a refund on a customer rma.

Without this, some policies are not being copied from the operation selected when creating new rma line from a rma group. In v16 this patch and the usage of such onchange can be removed in favor of (pre)computed stored editable fields for all policies and configuration in the RMA operation.

The goal is to simplify view defintion and do not duplicate things, requiring to do view changes in two places. The same change was done from rma lines some time ago.

This was not the intended way to add RMA lines to a group. Users are supposed to use the wizards to do so (add from stock move, add from serial, etc.). Having the option to use "add new line" was only leading to errors and confusion.

… in views

We shoul not force reservation on next steps on a multi step route, oherwise a inconsistency is generated and the transfers cannot be processed or cancel so the user gets stuck ("it is not possible to unreserve more products that you have in stock" error).

In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False. if any(picking.partner_id.id != m.partner_id.id or picking.origin != m.origin for m in moves): # If a picking is found, we'll append `move` to its move list and thus its # `partner_id` and `ref` field will refer to multiple records. In this # case, we chose to wipe them. picking.write({ 'partner_id': False, 'origin': False, }) In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move. In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.

…ma lines created (#452) * [14.0][IMP] added default operation on rma group, easy setup before rma lines created * [IMP] added fields for default route created by wizard on rma group * fix: get right price after create rma order line

qty_done -> quantity reserved_qty field does no exist anymore

When returning or delivering a serial product from a RMA, we will calculate by default its package. Later, it can be modyfied by the user.

… 'Customers' location

When looking at stock moves created from a rma group, it may be confusing knowing who's move is for which RMA line. This improvement should avoid these confusions.

Commits on Jul 12, 2024

[FIX] rma: vendor rma lot mnmg

AaronHForgeFlow committed Jul 12, 2024

Configuration menu

View commit details

Copy full SHA for 2c9a213

Browse repository at this point

Copy the full SHA

2c9a213 View commit details

Browse the repository at this point in the history

Commits on Aug 7, 2024

[IMP] rma: adapt icon to v17

AaronHForgeFlow committed Aug 7, 2024

Configuration menu

View commit details

Copy full SHA for 2ac6255

Browse repository at this point

Copy the full SHA

2ac6255 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] rma #512

[17.0][MIG] rma #512

Commits on May 6, 2024

Commits on May 8, 2024

Commits on Jul 8, 2024

Commits on Jul 12, 2024

Commits on Aug 7, 2024