Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/AdvancedOptions #186

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Hotfix/AdvancedOptions #186

wants to merge 12 commits into from

Conversation

jupster
Copy link
Collaborator

@jupster jupster commented May 28, 2024 •
edited
Loading

Description

Fixes Advanced Options

Motivation and Context

Closes 184

How Has This Been Tested?

With tears

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

*Still to fix Output to update on click rather then on click of something outside of Advanced Options

@jupster jupster added bug Something isn't working cleanup change labels May 28, 2024
@jupster jupster added this to the 1.9 milestone May 28, 2024
@jupster jupster self-assigned this May 28, 2024
@jupster jupster linked an issue May 28, 2024 that may be closed by this pull request
[BUG]LogObjectNotFound not implemented correctly #184
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jupster
Copy link
Collaborator Author

jupster commented Oct 11, 2024

Sonar out here emailing me now 😑

@jupster jupster marked this pull request as ready for review October 13, 2024 11:55
jupster
jupster commented Oct 13, 2024
View reviewed changes
FASTER/Models/ServerCfg.cs Outdated
}
}

public Advancedoptions()
Copy link
Collaborator Author

@jupster jupster Oct 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L839-L851 needs to be changed/fixed

FASTER/FASTER.csproj Outdated Show resolved Hide resolved
FASTER/Models/ServerCfg.cs Outdated Show resolved Hide resolved
jupster
jupster commented Oct 13, 2024
View reviewed changes
FASTER/Models/ServerProfile.cs
p.BasicCfg.BasicContent = p.BasicCfg.ProcessFile();
p.ArmaProfile.ArmaProfileContent = p.ArmaProfile.ProcessFile();
p.ServerCfg.ServerCfgContent = p.ServerCfg.ProcessFile();
p.ServerCfg.ServerCfgContent = p.AdvancedOptions.ProcessFile();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go over this file again as it might be why ProcessFile isn't working

@OverlordZorn OverlordZorn mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jupster jupster

Labels
bug Something isn't working change cleanup
Projects
FASTER
Status: In progress
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

[BUG]LogObjectNotFound not implemented correctly
1 participant
@jupster