add NDEBUG test - add build_test target - fix asserts
#2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbeltzun
added
type: bug
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
from
da06b90 to
b3bfdfa
Compare
tbeltzun
changed the title
NDEBUG test - add unitests targetNDEBUG test - add unittests target
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
from
b3bfdfa to
f1860ef
Compare
5 tasks
wrtobin
approved these changes
Oct 6, 2023
wrtobin
added
type: build system
|
CI is still behaving weirdly though, because according to #2631 (comment), this test should not pass at the moment (GEOS-DEV/thirdPartyLibs#243 / #2700 would be needed).
EDIT: this is now fixed, and the tests now errors as expected. |
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
2 times, most recently
from
edd78c2 to
cfdfabf
Compare
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
from
cfdfabf to
e192b62
Compare
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
from
a9a03c4 to
39833f4
Compare
Algiane
approved these changes
Nov 16, 2023
|
Thanks for all the work that you have done on this PR @tbeltzun ;-). |
TotoGaz
reviewed
Nov 17, 2023
Comment on lines
22
to
23
| * instead, we always check that this test fails in CMake Debug mode, whilst it should always | ||
| * pass in RelWithDebInfo or Release builds. |
There was a problem hiding this comment.
this test is compact and readable
No, this current test is not compact: it spans two files to be understood.
Both testToolChain.cpp and the corresponding CMakeLists.txt are involved in the pattern.
(Plus the "negate" pattern that will negate all the tests in the folder, not only this one).
Is the code below equivalent to the full logic on the test?
bool constexpr isDebug = std::string_view( GEOSX_CMAKE_BUILD_TYPE ) == std::string_view( "Debug" );
#ifdef NDEBUG
bool constexpr hasNDEBUG = true;
#else
bool constexpr hasNDEBUG = false;
#endif
ASSERT_EQ( !isDebug, hasNDEBUG ); // or static_assert(...)
rrsettgast
approved these changes
Nov 17, 2023
|
Ready on my side. |
|
@TotoGaz Are you ok with this ? |
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
from
dd84565 to
209c066
Compare
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
2 times, most recently
from
335af4c to
924ee83
Compare
tbeltzun
force-pushed
the
bugfix/tbeltzun/ndebug
branch
from
924ee83 to
753f192
Compare
2 tasks
2 tasks
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* add `DNDEBUG` test case * add `build_unittests` to build all the test targets * implement `geos_add_test` * enforce `CMake` consistency (tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addition of a
NDEBUGtestAdd a test for the HDF5 propagated flags as explained in #2631 and #2699 or GEOS-DEV/thirdPartyLibs#248.
In
DebugCMake configuration, if theDNDEBUGflag is propagated by any dependencies from the TPLs, this test should fail.addition of a
build_testtargetIt is well known (CMake limitation) that running
make testdoesn't build the tests and only tries to run them (see here).There is no dedicated target to enable building all the unitests executables at once apart from running
make all(which I want to avoid because it builds targets that I don't need from the C++ side).This PR add a
build_testtarget such that runningmake geosx build_test testbuilds geosx, the unitests, and runs the test suite.remove erroneous assertion
Authored by @Algiane.
Description duplicated from #2699:
According to geos code and doc:
numNodesInFaceis the number of nodes along the face of an element (getFaceNodesmethod);numNodes = lowestNodeToFaces.size();(see numNodes setting);lowestNodeToFacesis of sizem_numNodes(that is the number of nodes on the partition) (see lowestNodeToFaces allocation).Note that this erroneous assertion is not detected by the ci due to the transfer of theNDEBUGflag of the hdf5 build toward the geos compilation flags through Conduit (see TPL PR #243 and Geos PR #2700 where the assertion is executed .)Fixes #2700. Closes #2631.
enhance
CMakeLists.txtconsistencyset(dependencyList ${dependencyList} geosx_core)patterns withlist(APPEND dependencyList geosx_core), which is more concise;unset(something)instead ofset(something), for clarity;CMakeLists.txt.