-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] acoustic - elastic coupling (SEM, 2ⁿᵈ order wave equation) #2557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbeltzun
force-pushed
the
feature/tbeltzun/acous-elas-sem
branch
from
July 7, 2023 12:45
8d179b4
to
4fd1159
Compare
Validation run against gar6more3d: Acoustic receivers:
Elastic receivers:
|
This was referenced Sep 28, 2023
Merged
This was referenced Sep 29, 2023
Superseded by #2813 (cleanup). |
TotoGaz
pushed a commit
that referenced
this pull request
Dec 14, 2023
The rewrite of #2729 introduced a bug in the elastic solver, where the derived class had members shadowing the parent class variables. The cleanup was done in #2557 but was somehow missed when cherry-picking commits to create #2729. This PR: - fixes elastic solver bug (member variables shadowing), reported by @shenchengyi, reproducer using `inputFiles/wavePropagation/elas3D_DAS_smoke.xml`: empty seismos time and sampled value; - make `initTrace` consistent with `writeSeismoTrace` i.e. don't touch the file if `outputSeismoTrace` is unset; - remove redundant / unused `ElasticWaveEquationSEM::getNumNodesPerElem`; - code style consistency across `wavePropagation` solvers files (e.g. use `e` for element); - use `pow(..., n)` patterns for clarity.
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
The rewrite of #2729 introduced a bug in the elastic solver, where the derived class had members shadowing the parent class variables. The cleanup was done in #2557 but was somehow missed when cherry-picking commits to create #2729. This PR: - fixes elastic solver bug (member variables shadowing), reported by @shenchengyi, reproducer using `inputFiles/wavePropagation/elas3D_DAS_smoke.xml`: empty seismos time and sampled value; - make `initTrace` consistent with `writeSeismoTrace` i.e. don't touch the file if `outputSeismoTrace` is unset; - remove redundant / unused `ElasticWaveEquationSEM::getNumNodesPerElem`; - code style consistency across `wavePropagation` solvers files (e.g. use `e` for element); - use `pow(..., n)` patterns for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP for the acoustic - elastic coupling in SEM for the second order wave equation.
PRs required:
computeSeismoTrace
- addwriteSeismoTrace
#2641:--output
cli flag fix;NDEBUG
test - addbuild_test
target - fix asserts #2721;SIGFPE
invtk
#2718;WaveSolverBase
structure #2729;Linked issues:
High order
FEM
visualization #2592: high order solution visualization (nodes and elements);Allocating fields on sets #166: a workaround using node sets is currently used.
normals signs
test slanted interface & domain swap
validate against
gar6more3d
investigate