Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support high order hex Q2 output in VTK #2722

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

tbeltzun
Copy link
Contributor

@tbeltzun tbeltzun commented Sep 28, 2023

Q2 GLL nodes coincide with a regular grid, so handling Q2 nodes is un-ambiguous in VTK.

Credit for this PR goes to @Algiane .

Moved out of #2557.

@tbeltzun tbeltzun added the type: feature New feature or request label Sep 28, 2023
@tbeltzun tbeltzun self-assigned this Sep 28, 2023
@tbeltzun tbeltzun force-pushed the feature/tbeltzun/Q2-viz branch from 4ab8756 to 0567333 Compare September 28, 2023 14:57
@tbeltzun tbeltzun force-pushed the feature/tbeltzun/Q2-viz branch from 0567333 to 4bbc913 Compare September 28, 2023 14:58
@tbeltzun tbeltzun added flag: ready for review type: visualization VTK, Silo, ... ci: run CUDA builds Allows to triggers (costly) CUDA jobs labels Sep 28, 2023
@tbeltzun tbeltzun removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Oct 6, 2023
@tbeltzun tbeltzun requested review from CusiniM and klevzoff October 6, 2023 09:08
Copy link
Contributor

@klevzoff klevzoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbeltzun tbeltzun force-pushed the feature/tbeltzun/Q2-viz branch from d8c04e4 to 4f7b6a4 Compare October 9, 2023 06:32
@tbeltzun tbeltzun added ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed flag: ready for review labels Oct 9, 2023
@rrsettgast rrsettgast merged commit a1aeeee into develop Oct 11, 2023
17 checks passed
@rrsettgast rrsettgast deleted the feature/tbeltzun/Q2-viz branch October 11, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs type: feature New feature or request type: visualization VTK, Silo, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants