Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO: filter mesh levels for VTK #2723

Merged
merged 19 commits into from
Dec 12, 2023
Merged

IO: filter mesh levels for VTK #2723

merged 19 commits into from
Dec 12, 2023

Conversation

tbeltzun
Copy link
Contributor

@tbeltzun tbeltzun commented Sep 28, 2023 •
edited by TotoGaz
Loading

Add the ability to filter mesh levels to avoid saving un-needed data (as e.g. in the case of high-order SEM visualization).

A rebaseline is probably needed since this PR changes the VTK output from our wave solvers.

Moved out of #2557.

Rebaseline: GEOS-DEV/integratedTests#67

@tbeltzun tbeltzun added type: feature New feature or request type: visualization VTK, Silo, ... labels Sep 28, 2023
@tbeltzun tbeltzun self-assigned this Sep 28, 2023
@tbeltzun tbeltzun added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review labels Sep 28, 2023
@tbeltzun tbeltzun force-pushed the feature/tbeltzun/level-names-vtk branch from 176e5db to 681598f Compare September 29, 2023 07:43
@tbeltzun tbeltzun mentioned this pull request Sep 29, 2023
Closed
5 tasks
@tbeltzun tbeltzun added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs labels Oct 6, 2023
@tbeltzun tbeltzun requested review from TotoGaz and rrsettgast October 6, 2023 09:14
@tbeltzun tbeltzun mentioned this pull request Nov 10, 2023
Merged
4 tasks
@tbeltzun tbeltzun added ci: run CUDA builds Allows to triggers (costly) CUDA jobs and removed flag: ready for review labels Nov 15, 2023
@tbeltzun tbeltzun force-pushed the feature/tbeltzun/level-names-vtk branch from 7336209 to 1ac8cb3 Compare November 15, 2023 09:32
@tbeltzun tbeltzun added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Nov 17, 2023
@TotoGaz
Copy link
Contributor

TotoGaz commented Dec 11, 2023

Hi @tbeltzun there are conflict in the rst files. Can you fix those then we can merge your PR

@TotoGaz TotoGaz mentioned this pull request Dec 12, 2023
Merged
@TotoGaz TotoGaz merged commit acbed1a into develop Dec 12, 2023
20 checks passed
@TotoGaz TotoGaz deleted the feature/tbeltzun/level-names-vtk branch December 12, 2023 03:11
ouassimkh pushed a commit that referenced this pull request Feb 16, 2024
@tbeltzun @ouassimkh
IO: filter mesh levels for VTK (#2723)
73664f8 
Add the ability to filter mesh levels to avoid saving un-needed data (as e.g. in the case of high-order SEM visualization).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CusiniM CusiniM CusiniM left review comments

@TotoGaz TotoGaz TotoGaz approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

Assignees

@tbeltzun tbeltzun

Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: feature New feature or request type: visualization VTK, Silo, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbeltzun @TotoGaz @CusiniM