rewrite seismo traces - rework WaveSolverBase structure
#2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbeltzun
added
type: bug
5 tasks
tbeltzun
force-pushed
the
bugfix/tbeltzun/seismo-rewrite
branch
from
1bf2359 to
bb54aed
Compare
acitrain
approved these changes
Oct 13, 2023
tbeltzun
added
ci: run CUDA builds
4 tasks
TotoGaz
pushed a commit
that referenced
this pull request
Dec 14, 2023
The rewrite of #2729 introduced a bug in the elastic solver, where the derived class had members shadowing the parent class variables. The cleanup was done in #2557 but was somehow missed when cherry-picking commits to create #2729. This PR: - fixes elastic solver bug (member variables shadowing), reported by @shenchengyi, reproducer using `inputFiles/wavePropagation/elas3D_DAS_smoke.xml`: empty seismos time and sampled value; - make `initTrace` consistent with `writeSeismoTrace` i.e. don't touch the file if `outputSeismoTrace` is unset; - remove redundant / unused `ElasticWaveEquationSEM::getNumNodesPerElem`; - code style consistency across `wavePropagation` solvers files (e.g. use `e` for element); - use `pow(..., n)` patterns for clarity.
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* rewrite seismo traces - rework `WaveSolverBase` structure * format * fix tests * update submodules * update PR for VTI * consistency * update submodules * updated integratedTests submodule * Updating schema * Updating the integratedTests hash --------- Co-authored-by: Julien Rene Thomas Besset <[email protected]> Co-authored-by: acitrain <[email protected]> Co-authored-by: Pavel Tomin <[email protected]> Co-authored-by: Nicola Castelletto <[email protected]>
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
The rewrite of #2729 introduced a bug in the elastic solver, where the derived class had members shadowing the parent class variables. The cleanup was done in #2557 but was somehow missed when cherry-picking commits to create #2729. This PR: - fixes elastic solver bug (member variables shadowing), reported by @shenchengyi, reproducer using `inputFiles/wavePropagation/elas3D_DAS_smoke.xml`: empty seismos time and sampled value; - make `initTrace` consistent with `writeSeismoTrace` i.e. don't touch the file if `outputSeismoTrace` is unset; - remove redundant / unused `ElasticWaveEquationSEM::getNumNodesPerElem`; - code style consistency across `wavePropagation` solvers files (e.g. use `e` for element); - use `pow(..., n)` patterns for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computeAllSeismoTracesandcompute2dVariableAllSeismoTracestoWaveSolverBase;WaveSolverBaseand move members (such asm_rcvElemorm_receiverRegion) / keys from children solvers to parent class;computeAllSeismoTracesfor loops for clarity;writeSeismoTrace;writeSeismoTraceVectorhelper;initTraceto avoid appending to an initial seismo trace;time, enhance robustness.Rebaseline PR: GEOS-DEV/integratedTests#48.
Moved out of #2557.