rewrite wave propagation damping kernels #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbeltzun
added
type: bug
5 tasks
tbeltzun
requested review from
acitrain and
sframba
and removed request for
acitrain
tbeltzun
added
the
flag: requires rebaseline
sframba
added
ci: run CUDA builds
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix OOB error in the computation of damping kernels while developing the coupled acousto-elastic solver.
Loop over elements (then on face per element) instead of all domain faces to pre-compute the boundary damping terms.
Should be a noop regarding integrated tests (or maybe up to an numerical epsilon w.r.t. summation order).
Moved out of #2557.