Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplification & consolidation of CellElementRegion definition #2878

Merged
merged 146 commits into from
Oct 17, 2024

rebaseline (2nd attempt)

410b9d5
Select commit
Loading
Failed to load commit list.
Merged

feat: Simplification & consolidation of CellElementRegion definition #2878

rebaseline (2nd attempt)
410b9d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 17, 2024 in 0s

56.79% (+0.31%) compared to 263e5fd

View this Pull Request on Codecov

56.79% (+0.31%) compared to 263e5fd

Details

Codecov Report

Attention: Patch coverage is 92.43243% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (263e5fd) to head (410b9d5).

Files with missing lines Patch % Lines
...ponents/unitTests/meshTests/testElementRegions.cpp 73.68% 10 Missing ⚠️
src/coreComponents/mesh/ElementType.hpp 82.35% 3 Missing ⚠️
...c/coreComponents/common/format/StringUtilities.hpp 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2878      +/-   ##
===========================================
+ Coverage    56.47%   56.79%   +0.31%     
===========================================
  Files         1074     1076       +2     
  Lines        90504    95743    +5239     
===========================================
+ Hits         51116    54377    +3261     
- Misses       39388    41366    +1978

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov