feat: Transmissibility output

src/coreComponents/common/Logger.hpp

@@ -516,6 +516,23 @@ struct SimulationError : public std::runtime_error
   SimulationError( std::exception const & subException, std::string const & msgToInsert );
 };
 
+/**
+ * @brief Exception class used to report errors from type conversion
+ * @todo (ErrorManager EPIC #2940) Consider adding a way to precise custom exception parameters, to add
+ * expected & encountered typeid for this one (in order to manage the exception output more precisely).
+ * We could also manage this by having:    BadTypeErrorABC <|--- BadTypeError< T >      /!\ compilation time
+ */
+struct BadTypeError : public std::runtime_error
+{
+  /**
+   * @brief Constructor
+   * @param what the error message
+   */
+  BadTypeError( std::string const & what ):
+    std::runtime_error( what )
+  {}
+};
+
 /**
  * @brief Exception class used for special control flow.
  */

src/coreComponents/common/Units.hpp

@@ -94,6 +94,9 @@ enum Unit : integer
 
   /// Mole rate in mol/s
   MoleRate,
+
+  /// Transmissibility in m2/s
+  Transmissibility,
 };
 
 
@@ -105,21 +108,22 @@ constexpr inline std::string_view getDescription( Unit unit )
 {
   switch( unit )
   {
-    default:              return "unknown [?]";
-    case Dimensionless:   return "dimensionless [1]";
-    case Pressure:        return "pressure [Pa]";
-    case Temperature:     return "temperature [K]";
-    case TemperatureInC:  return "temperature [C]";
-    case Distance:        return "distance [m]";
-    case Time:            return "time [s]";
-    case Viscosity:       return "viscosity [Pa*s]";
-    case Enthalpy:        return "enthalpy [J/kg]";
-    case Density:         return "density [kg/m3]";
-    case Solubility:      return "solubility [g/L]";
-    case Mass:            return "mass [kg]";
-    case Mole:            return "mole [mol]";
-    case MassRate:        return "mass rate [kg/s]";
-    case MoleRate:        return "mole rate [mol/s]";
+    default:                return "unknown [?]";
+    case Dimensionless:     return "dimensionless [1]";
+    case Pressure:          return "pressure [Pa]";
+    case Temperature:       return "temperature [K]";
+    case TemperatureInC:    return "temperature [C]";
+    case Distance:          return "distance [m]";
+    case Time:              return "time [s]";
+    case Viscosity:         return "viscosity [Pa*s]";
+    case Enthalpy:          return "enthalpy [J/kg]";
+    case Density:           return "density [kg/m3]";
+    case Solubility:        return "solubility [g/L]";
+    case Mass:              return "mass [kg]";
+    case Mole:              return "mole [mol]";
+    case MassRate:          return "mass rate [kg/s]";
+    case MoleRate:          return "mole rate [mol/s]";
+    case Transmissibility:  return "transmissibility [(Pa*s*rm3/s)/Pa]";
   }
 }
 
@@ -131,21 +135,22 @@ constexpr inline std::string_view getSymbol( Unit unit )
 {
   switch( unit )
   {
-    default:              return "?";
-    case Dimensionless:   return "1";
-    case Pressure:        return "Pa";
-    case Temperature:     return "K";
-    case TemperatureInC:  return "C";
-    case Distance:        return "m";
-    case Time:            return "s";
-    case Viscosity:       return "Pa*s";
-    case Enthalpy:        return "J/kg";
-    case Density:         return "kg/m3";
-    case Solubility:      return "g/L";
-    case Mass:            return "kg";
-    case Mole:            return "mol";
-    case MassRate:        return "kg/s";
-    case MoleRate:        return "mol/s";
+    default:                return "?";
+    case Dimensionless:     return "1";
+    case Pressure:          return "Pa";
+    case Temperature:       return "K";
+    case TemperatureInC:    return "C";
+    case Distance:          return "m";
+    case Time:              return "s";
+    case Viscosity:         return "Pa*s";
+    case Enthalpy:          return "J/kg";
+    case Density:           return "kg/m3";
+    case Solubility:        return "g/L";
+    case Mass:              return "kg";
+    case Mole:              return "mol";
+    case MassRate:          return "kg/s";
+    case MoleRate:          return "mol/s";
+    case Transmissibility:  return "(Pa*s*rm3/s)/Pa";
   }
 }
 
@@ -160,21 +165,22 @@ inline string formatValue( real64 value, Unit unit )
 {
   switch( unit )
   {
-    default:              return GEOS_FMT( "value of {} [?]", value );
-    case Dimensionless:   return GEOS_FMT( "value of {} [1]", value );
-    case Pressure:        return GEOS_FMT( "pressure of {} [Pa]", value );
-    case Temperature:     return GEOS_FMT( "temperature of {} [K]", value );
-    case TemperatureInC:  return GEOS_FMT( "temperature of {} [K]", convertCToK( value ) );
-    case Distance:        return GEOS_FMT( "distance of {} [s]", value );
-    case Time:            return GEOS_FMT( "time of {} [s]", value );
-    case Viscosity:       return GEOS_FMT( "viscosity of {} [Pa*s]", value );
-    case Enthalpy:        return GEOS_FMT( "enthalpy of {} [J/kg]", value );
-    case Density:         return GEOS_FMT( "density of {} [kg/m3]", value );
-    case Solubility:      return GEOS_FMT( "solubility of {} [g/L]", value );
-    case Mass:            return GEOS_FMT( "mass of {} [kg]", value );
-    case Mole:            return GEOS_FMT( "mole of {} [mol]", value );
-    case MassRate:        return GEOS_FMT( "mass rate of {} [kg/s]", value );
-    case MoleRate:        return GEOS_FMT( "mole rate of {} [mol/s]", value );
+    default:                return GEOS_FMT( "value of {} [?]", value );
+    case Dimensionless:     return GEOS_FMT( "value of {} [1]", value );
+    case Pressure:          return GEOS_FMT( "pressure of {} [Pa]", value );
+    case Temperature:       return GEOS_FMT( "temperature of {} [K]", value );
+    case TemperatureInC:    return GEOS_FMT( "temperature of {} [K]", convertCToK( value ) );
+    case Distance:          return GEOS_FMT( "distance of {} [s]", value );
+    case Time:              return GEOS_FMT( "time of {} [s]", value );
+    case Viscosity:         return GEOS_FMT( "viscosity of {} [Pa*s]", value );
+    case Enthalpy:          return GEOS_FMT( "enthalpy of {} [J/kg]", value );
+    case Density:           return GEOS_FMT( "density of {} [kg/m3]", value );
+    case Solubility:        return GEOS_FMT( "solubility of {} [g/L]", value );
+    case Mass:              return GEOS_FMT( "mass of {} [kg]", value );
+    case Mole:              return GEOS_FMT( "mole of {} [mol]", value );
+    case MassRate:          return GEOS_FMT( "mass rate of {} [kg/s]", value );
+    case MoleRate:          return GEOS_FMT( "mole rate of {} [mol/s]", value );
+    case Transmissibility:  return GEOS_FMT( "transmissibility of {} [(Pa*s*rm3/s)/Pa]", value );
   }
 }
 

src/coreComponents/dataRepository/Group.hpp

@@ -337,8 +337,12 @@ class Group
                    "Group " << getDataContext() << " has no child named " << key << std::endl
                             << dumpSubGroupsNames(),
                    std::domain_error );
-
-    return dynamicCast< T & >( *child );
+    T * const castedChild = dynamicCast< T * >( child );
+    GEOS_THROW_IF( castedChild == nullptr,
+                   GEOS_FMT( "{} was expected to be a '{}'.",
+                             child->getDataContext(), LvArray::system::demangleType< T >() ),
+                   BadTypeError );
+    return *castedChild;
   }
 
   /**
@@ -352,8 +356,12 @@ class Group
                    "Group " << getDataContext() << " has no child named " << key << std::endl
                             << dumpSubGroupsNames(),
                    std::domain_error );
-
-    return dynamicCast< T const & >( *child );
+    T const * const castedChild = dynamicCast< T const * >( child );
+    GEOS_THROW_IF( castedChild == nullptr,
+                   GEOS_FMT( "{} was expected to be a '{}'.",
+                             child->getDataContext(), LvArray::system::demangleType< T >() ),
+                   BadTypeError );
+    return *castedChild;
   }
 
   /**

src/coreComponents/fileIO/timeHistory/PackCollection.cpp

@@ -57,6 +57,7 @@ void PackCollection::initializePostSubGroups( )
     {
       // coord meta collectors should have m_disableCoordCollection == true to avoid
       //  infinite recursive init calls here
+      //          (side note: should we create a m_isMetaCollector field to prevent any confusion?)
       metaCollector->initializePostSubGroups();
     }
     m_initialized = true;
@@ -240,7 +241,7 @@ localIndex PackCollection::numMetaDataCollectors() const
 
 void PackCollection::buildMetaDataCollectors()
 {
-  if( !m_disableCoordCollection )
+  if( !m_disableCoordCollection && m_targetIsMeshObject )
   {
     char const * coordField = nullptr;
     if( m_objectPath.find( "nodeManager" ) != string::npos )