feat: Temperature dependent single phase thermal conductivity #3135

sytuannguyen · 2024-05-22T08:05:11Z

This PR is part of the project for non-linear thermal constitutive behavior from TotalEnergies. It tackles the problem of linear temperature dependent single phase effective thermal conductivity of porous medium.

thermalConductivity = defaultThermalConductivity + dThermalConductivity_dT * (T - T_reference)

where defaultThermalConductivity, dThermalConductivity_dT and T_reference are given in the xml inputs. The existing linear model in GEOS corresponds to the particular case of a constant thermal conductivity, i.e. dThermalConductivity_dT = 0.

Implement the non linear thermal constitutive model
Update the thermal single phase flow with respect to non linear thermal behavior
Update xml files to add new inputs: dThermalConductivity_dT and T_reference
Integrated test
Unit test
Validation example: doc and Python script for validation

…ctivity

…lConductivity

herve-gross

Thank you Sy Tuan. Lots of change in this PR, but everything looks in order.

codecov · 2024-06-26T02:54:24Z

Codecov Report

Attention: Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (6f9c1b4) to head (6e7b2f6).
Report is 91 commits behind head on develop.

Files with missing lines	Patch %	Lines
...Solvers/fluidFlow/ThermalSinglePhaseFVMKernels.hpp	46.15%	7 Missing ⚠️
...onductivity/SinglePhaseThermalConductivityBase.hpp	0.00%	2 Missing ⚠️
...malConductivity/SinglePhaseThermalConductivity.cpp	98.11%	1 Missing ⚠️
...onductivity/SinglePhaseThermalConductivityBase.cpp	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3135      +/-   ##
===========================================
+ Coverage    56.58%   56.59%   +0.01%     
===========================================
  Files         1064     1064              
  Lines        89715    89752      +37     
===========================================
+ Hits         50763    50793      +30     
- Misses       38952    38959       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp

CusiniM · 2024-08-12T16:46:37Z

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp

+  } );
+}
+
+void SinglePhaseThermalConductivity::updateFromTemperature( arrayView1d< real64 const > const & temperature ) const


this is not really how things are usually done in GEOS since we usually have these update functions in the kernelWrapper objects.

Before this PR, there is an "update" function here, I just replace it by this function. By doing so, I did not intend to change the architecture design of GEOS.

…lConductivity

CusiniM

Can we find a better name to replace ThermalConductivityGradientComponents?

CusiniM · 2024-08-14T15:22:17Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

@@ -11,7 +11,7 @@
      targetRegions="{ region }">
      <NonlinearSolverParameters
        newtonTol="1.0e-6"
-        newtonMaxIter="10"/>
+        newtonMaxIter="100"/>


why? is this case taking 100 nonlinear iterations?

20 would be sufficient

This number is to ensure the convergence of the benchmark case

I should converge in 20. if not, then something is wrong.

I can confirm that it converges in 20.

CusiniM · 2024-08-14T15:25:35Z

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp

+  return SinglePhaseThermalConductivityBase::deliverClone( name, parent );
+}
+
+void SinglePhaseThermalConductivity::initializeRockFluidState( arrayView2d< real64 const > const & initialPorosity ) const


well, can we change it? I don't understand why it would use the porosity. And the name is quite confusing.

CusiniM · 2024-08-14T15:29:09Z

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.hpp

+   * @brief Getter for the derivative of effective conductivities in the subRegion w.r.t. temperature
+   * @return an arrayView of derivative of effective conductivities w.r.t. temperature
+   */
+  arrayView3d< real64 const > dEffectiveConductivity_dT() const { return m_dEffectiveConductivity_dT; }


do you need this?

Yes, absolutly, adding this term is the core of this implementation for temperature dependent single phase thermal conductivity.

Does it need to be in the base class? Can it be in the SinglePhaseThermalConductivity class itself. I can imagine we might later have thermal conductivity models that don't need this.

I meant "do you need this getter"? We have specific ways to grab fields from consitutive models through getField

jhuang2601 · 2024-08-14T19:20:00Z

Can we find a better name to replace ThermalConductivityGradientComponents?

How about ThermalConductivityGradient?

sytuannguyen · 2024-08-15T00:37:45Z

Can we find a better name to replace ThermalConductivityGradientComponents?

How about ThermalConductivityGradient?

From my point of view, ThermalConductivityGradientComponents is more appropriate because it stands for the components of the thermal gradient vector, also it is consistent to the existing name ThermalConductivityComponents for the components of the thermal conductivity.

…lConductivity

CusiniM · 2024-08-25T20:18:54Z

This PR still needs a codeowner's review so I cannot merge it. Let's not put in the merge queue PR's that still need approval because they clog it.

sytuannguyen · 2024-08-26T12:27:04Z

This PR still needs a codeowner's review so I cannot merge it. Let's not put in the merge queue PR's that still need approval because they clog it.

What does this means? Do you mean this PR need to be validated by all the 10 code owners or just some of you?

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.hpp

dkachuma · 2024-08-26T14:57:04Z

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivityBase.hpp

+   * @brief Getter for the derivative of effective conductivities in the subRegion w.r.t. temperature
+   * @return an arrayView of derivative of effective conductivities w.r.t. temperature
+   */
+  arrayView3d< real64 const > dEffectiveConductivity_dT() const { return m_dEffectiveConductivity_dT; }


Does it need to be in the base class? Can it be in the SinglePhaseThermalConductivity class itself. I can imagine we might later have thermal conductivity models that don't need this.

CusiniM · 2024-08-26T16:20:54Z

This PR still needs a codeowner's review so I cannot merge it. Let's not put in the merge queue PR's that still need approval because they clog it.

What does this means? Do you mean this PR need to be validated by all the 10 code owners or just some of you?

Only 1 code owner for each folder that was modified by the PR.

jhuang2601 · 2024-08-26T20:01:34Z

Hello @rrsettgast, please take a look on this PR, which is waiting for your approval.

rrsettgast · 2024-08-26T22:11:40Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

@@ -11,7 +11,7 @@
      targetRegions="{ region }">
      <NonlinearSolverParameters
        newtonTol="1.0e-6"
-        newtonMaxIter="10"/>
+        newtonMaxIter="100"/>


I should converge in 20. if not, then something is wrong.

jhuang2601 · 2024-08-27T12:36:21Z

inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml

@@ -11,7 +11,7 @@
      targetRegions="{ region }">
      <NonlinearSolverParameters
        newtonTol="1.0e-6"
-        newtonMaxIter="10"/>
+        newtonMaxIter="100"/>


I can confirm that it converges in 20.

…lConductivity

sytuannguyen added 11 commits May 15, 2024 05:48

prepare for implementing linear solid thermal conductivity

901e4b7

update the thermal conductivity constitutive class

158bb3e

update the name of the thermal conductivity model in xml files

5303002

update thermal model name in srt and py files

89b7909

add thermal model name to coupled constitutive model

fde823e

add cond gradient attribute and update xmls

541976e

update thermal single phase FVM kernel w.r.t. non const thermal condu…

3e3676a

…ctivity

add dThermalCond_dT to single phase thermal flow solver

233f100

fix floating point exception

4219e49

add thermal conductivity derivative to kernel

6ae57b7

Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…

4de8fab

…lConductivity

sytuannguyen added type: feature New feature or request changes XML input labels May 22, 2024

sytuannguyen requested review from herve-gross and jhuang2601 May 22, 2024 08:05

sytuannguyen self-assigned this May 22, 2024

herve-gross approved these changes May 22, 2024

View reviewed changes

jhuang2601 mentioned this pull request Jun 4, 2024

[EPIC] Temperature dependent mechanical properties #2535

Open

5 tasks

fix conflict

826172b

sytuannguyen marked this pull request as ready for review June 26, 2024 01:38

sytuannguyen added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests labels Jun 26, 2024

sytuannguyen added 3 commits June 26, 2024 03:46

uncrustify_style

0c341e9

add doc and python script for validation

5aa2b77

update thermal unit tests

26b7ac4

sytuannguyen added 3 commits June 26, 2024 05:30

add integrated test and xmls for benchmark

a024785

update doc and Python script

cf70f7d

fix unit test

39d8e3f

CusiniM reviewed Aug 12, 2024

View reviewed changes

src/coreComponents/constitutive/thermalConductivity/SinglePhaseThermalConductivity.cpp Outdated Show resolved Hide resolved

CusiniM reviewed Aug 12, 2024

View reviewed changes

sytuannguyen and others added 3 commits August 13, 2024 03:35

address comments

4810e0f

merge develop and resolve conflict

07dfcbf

Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…

bdd425b

…lConductivity

CusiniM reviewed Aug 14, 2024

View reviewed changes

CusiniM approved these changes Aug 15, 2024

View reviewed changes

paveltomin approved these changes Aug 15, 2024

View reviewed changes

rrsettgast and others added 2 commits August 22, 2024 06:20

Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…

8b94b00

…lConductivity

update integratedTests tags

2647b31

dkachuma approved these changes Aug 26, 2024

View reviewed changes

corbett5 approved these changes Aug 26, 2024

View reviewed changes

rrsettgast approved these changes Aug 26, 2024

View reviewed changes

jhuang2601 approved these changes Aug 27, 2024

View reviewed changes

jhuang2601 added 5 commits August 30, 2024 12:16

Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…

14b7ce3

…lConductivity

update COPYRIGHT statement for one cpp file

cc215e1

Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…

53174a0

…lConductivity

update BASELINE_NOTES.md

60e4584

update .integrated_tests.yaml

6e7b2f6

CusiniM merged commit fda7ed2 into develop Sep 5, 2024
22 checks passed

CusiniM deleted the feature/sytuan/temperatureDependentThermalConductivity branch September 5, 2024 03:55

untereiner pushed a commit that referenced this pull request Sep 17, 2024

feat: Temperature dependent single phase thermal conductivity (#3135)

a060490

rrsettgast pushed a commit that referenced this pull request Sep 17, 2024

feat: Temperature dependent single phase thermal conductivity (#3135)

bf78e30

rrsettgast pushed a commit that referenced this pull request Sep 17, 2024

feat: Temperature dependent single phase thermal conductivity (#3135)

f719653

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Temperature dependent single phase thermal conductivity #3135

feat: Temperature dependent single phase thermal conductivity #3135

sytuannguyen commented May 22, 2024 •

edited

Loading

herve-gross left a comment

codecov bot commented Jun 26, 2024 •

edited

Loading

CusiniM Aug 12, 2024

sytuannguyen Aug 13, 2024 •

edited

Loading

CusiniM left a comment

CusiniM Aug 14, 2024

jhuang2601 Aug 14, 2024

sytuannguyen Aug 15, 2024

rrsettgast Aug 26, 2024

jhuang2601 Aug 27, 2024

CusiniM Aug 14, 2024

CusiniM Aug 14, 2024

sytuannguyen Aug 15, 2024

dkachuma Aug 26, 2024

CusiniM Aug 26, 2024

jhuang2601 commented Aug 14, 2024

sytuannguyen commented Aug 15, 2024

CusiniM commented Aug 25, 2024

sytuannguyen commented Aug 26, 2024

dkachuma Aug 26, 2024

CusiniM commented Aug 26, 2024

jhuang2601 commented Aug 26, 2024

rrsettgast Aug 26, 2024

jhuang2601 Aug 27, 2024

feat: Temperature dependent single phase thermal conductivity #3135

feat: Temperature dependent single phase thermal conductivity #3135

Conversation

sytuannguyen commented May 22, 2024 • edited Loading

herve-gross left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 26, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

sytuannguyen Aug 13, 2024 • edited Loading

Choose a reason for hiding this comment

CusiniM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhuang2601 commented Aug 14, 2024

sytuannguyen commented Aug 15, 2024

CusiniM commented Aug 25, 2024

sytuannguyen commented Aug 26, 2024

Choose a reason for hiding this comment

CusiniM commented Aug 26, 2024

jhuang2601 commented Aug 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sytuannguyen commented May 22, 2024 •

edited

Loading

codecov bot commented Jun 26, 2024 •

edited

Loading

sytuannguyen Aug 13, 2024 •

edited

Loading