Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Temperature dependent single phase thermal conductivity #3135

Merged
merged 60 commits into from
Sep 5, 2024
Merged

feat: Temperature dependent single phase thermal conductivity #3135

Show file tree
Hide file tree
Changes from 53 commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
901e4b7
prepare for implementing linear solid thermal conductivity
sytuannguyen May 15, 2024
158bb3e
update the thermal conductivity constitutive class
sytuannguyen May 15, 2024
5303002
update the name of the thermal conductivity model in xml files
sytuannguyen May 16, 2024
89b7909
update thermal model name in srt and py files
sytuannguyen May 16, 2024
fde823e
add thermal model name to coupled constitutive model
sytuannguyen May 16, 2024
541976e
add cond gradient attribute and update xmls
sytuannguyen May 16, 2024
3e3676a
update thermal single phase FVM kernel w.r.t. non const thermal condu…
sytuannguyen May 20, 2024
233f100
add dThermalCond_dT to single phase thermal flow solver
sytuannguyen May 21, 2024
4219e49
fix floating point exception
sytuannguyen May 22, 2024
6ae57b7
add thermal conductivity derivative to kernel
sytuannguyen May 22, 2024
4de8fab
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen May 22, 2024
826172b
fix conflict
sytuannguyen Jun 26, 2024
0c341e9
uncrustify_style
sytuannguyen Jun 26, 2024
5aa2b77
add doc and python script for validation
sytuannguyen Jun 26, 2024
26b7ac4
update thermal unit tests
sytuannguyen Jun 26, 2024
a024785
add integrated test and xmls for benchmark
sytuannguyen Jun 26, 2024
cf70f7d
update doc and Python script
sytuannguyen Jun 26, 2024
39d8e3f
fix unit test
sytuannguyen Jun 26, 2024
2f9a18e
more fix for unit test
sytuannguyen Jun 26, 2024
fd3a389
fix set apply default vector
sytuannguyen Jun 26, 2024
5d6ac8f
uncrustify_style
sytuannguyen Jun 27, 2024
20cea11
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen Jun 27, 2024
aeace94
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen Jun 29, 2024
1e39149
merge develop
sytuannguyen Jul 22, 2024
8aa1c83
add ThermalCompressibleSolid class
sytuannguyen Jul 23, 2024
18705ed
update xml
sytuannguyen Jul 23, 2024
f0caa6c
uncrustify_style
sytuannguyen Jul 23, 2024
ef365ac
fix an unit test
sytuannguyen Jul 23, 2024
9180501
add ThermoPoroMechanics class
sytuannguyen Jul 24, 2024
88abd53
uncrustify_style
sytuannguyen Jul 25, 2024
9453bc8
update the validation examples
sytuannguyen Jul 25, 2024
31d7853
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen Jul 25, 2024
9a3996a
fix python scripts
sytuannguyen Jul 25, 2024
894be09
update linear thermal diffusion example
sytuannguyen Jul 25, 2024
8df82ee
update a python script
sytuannguyen Jul 26, 2024
9ab1382
simplification
sytuannguyen Jul 29, 2024
50d6048
update xmls
sytuannguyen Jul 29, 2024
7af4efd
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen Jul 29, 2024
168df8e
update xmls
sytuannguyen Jul 29, 2024
ed5f588
remove redundant files
sytuannguyen Jul 29, 2024
8b8303f
some minor fixs
sytuannguyen Jul 29, 2024
bd3bb35
fix an unit test
sytuannguyen Jul 30, 2024
bd096dd
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
jhuang2601 Aug 1, 2024
c3152ab
add smoke tests for integratedTest
jhuang2601 Aug 1, 2024
8fadb85
add a doc for this new model
jhuang2601 Aug 1, 2024
5c6f798
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen Aug 5, 2024
f296222
address comments
sytuannguyen Aug 5, 2024
1fe01a9
Merge branch 'feature/sytuan/temperatureDependentThermalConductivity'…
sytuannguyen Aug 5, 2024
c28eeba
address comments
sytuannguyen Aug 12, 2024
5a059f7
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
sytuannguyen Aug 12, 2024
4810e0f
address comments
sytuannguyen Aug 13, 2024
07dfcbf
merge develop and resolve conflict
sytuannguyen Aug 13, 2024
bdd425b
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
jhuang2601 Aug 14, 2024
8b94b00
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
rrsettgast Aug 22, 2024
2647b31
update integratedTests tags
jhuang2601 Aug 22, 2024
14b7ce3
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
jhuang2601 Aug 30, 2024
cc215e1
update COPYRIGHT statement for one cpp file
jhuang2601 Aug 30, 2024
53174a0
Merge branch 'develop' into feature/sytuan/temperatureDependentTherma…
jhuang2601 Sep 3, 2024
60e4584
update BASELINE_NOTES.md
jhuang2601 Sep 4, 2024
6e7b2f6
update .integrated_tests.yaml
jhuang2601 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inputFiles/singlePhaseFlow/3D_10x10x10_thermalCompressible_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@
specificHeatCapacity="4.0e3"
referenceInternalEnergy="1.1e6"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 3.5, 3.5, 3.5 }"/>
defaultThermalConductivityComponents="{ 3.5, 3.5, 3.5 }"/>

</Constitutive>

Expand Down
36 changes: 23 additions & 13 deletions inputFiles/singlePhaseFlow/thermalCompressible_2d_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
targetRegions="{ region }">
<NonlinearSolverParameters
newtonTol="1.0e-6"
newtonMaxIter="10"/>
newtonMaxIter="100"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? is this case taking 100 nonlinear iterations?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 would be sufficient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number is to ensure the convergence of the benchmark case

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should converge in 20. if not, then something is wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it converges in 20.

<LinearSolverParameters
directParallel="0"/>
</SinglePhaseFVM>
Expand All @@ -34,7 +34,7 @@
solidInternalEnergyModelName="rockInternalEnergy_linear"/>

<CompressibleSolidConstantPermeability
name="rock_nonLinear"
name="rock_temperatureDependentVolumetricHeatCapacity"
solidModelName="nullSolid"
porosityModelName="rockPorosity"
permeabilityModelName="rockPerm"
Expand All @@ -49,13 +49,13 @@
referencePressure="0.0"
compressibility="3.0e-11"/>

<!-- SPHINX_SolidInternalEnergy -->
<!-- SPHINX_SolidInternalEnergy_linear -->
<SolidInternalEnergy
name="rockInternalEnergy_linear"
referenceVolumetricHeatCapacity="4.56e6"
referenceVolumetricHeatCapacity="1.0e6"
referenceTemperature="0"
referenceInternalEnergy="0"/>
<!-- SPHINX_SolidInternalEnergyEnd -->
<!-- SPHINX_SolidInternalEnergy_linearEnd -->

<!-- SPHINX_SolidInternalEnergy_nonLinear -->
<SolidInternalEnergy
Expand Down Expand Up @@ -84,11 +84,21 @@
referenceInternalEnergy="0.99"/>
<!-- SPHINX_ThermalCompressibleSinglePhaseFluidEnd -->

<!-- SPHINX_SinglePhaseConstantThermalConductivity -->
<SinglePhaseConstantThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 1.66, 1.66, 1.66 }"/>
<!-- SPHINX_SinglePhaseConstantThermalConductivityEnd -->
<!-- SPHINX_SinglePhaseThermalConductivity_linear -->
<SinglePhaseThermalConductivity
name="thermalCond_linear"
defaultThermalConductivityComponents="{ 1.66, 1.66, 1.66 }"
thermalConductivityGradientComponents="{ 0, 0, 0 }"
referenceTemperature="0"/>
<!-- SPHINX_SinglePhaseThermalConductivity_linearEnd -->

<!-- SPHINX_SinglePhaseThermalConductivity_nonLinear -->
<SinglePhaseThermalConductivity
name="thermalCond_nonLinear"
defaultThermalConductivityComponents="{ 1.5, 1.5, 1.5 }"
thermalConductivityGradientComponents="{ -12e-4, -12e-4, -12e-4 }"
referenceTemperature="20"/>
<!-- SPHINX_SinglePhaseThermalConductivity_nonLinearEnd -->

</Constitutive>

Expand Down Expand Up @@ -125,21 +135,21 @@
setNames="{ all }"
objectPath="ElementRegions/region/cb"
fieldName="temperature"
scale="0"/>
scale="100"/>

<FieldSpecification
name="sinkTemperature"
setNames="{ rpos }"
objectPath="faceManager"
fieldName="temperature"
scale="0"/>
scale="100"/>

<FieldSpecification
name="sourceTemperature"
setNames="{ rneg }"
objectPath="faceManager"
fieldName="temperature"
scale="100.0"/>
scale="-20.0"/>
<!-- SPHINX_FieldSpecificationImposedTemperatureEnd -->

</FieldSpecifications>
Expand Down
2 changes: 1 addition & 1 deletion inputFiles/singlePhaseFlow/thermalCompressible_2d_benchmark.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<CellElementRegion
name="region"
cellBlocks="{ cb }"
materialList="{ fluid, rock_linear, thermalCond }"/>
materialList="{ fluid, rock_linear, thermalCond_linear }"/>
</ElementRegions>

<Mesh>
Expand Down
2 changes: 1 addition & 1 deletion inputFiles/singlePhaseFlow/thermalCompressible_2d_smoke.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<CellElementRegion
name="region"
cellBlocks="{ cb }"
materialList="{ fluid, rock_nonLinear, thermalCond }"/>
materialList="{ fluid, rock_linear, thermalCond_linear }"/>
</ElementRegions>

<Mesh>
Expand Down
2 changes: 1 addition & 1 deletion ...alCompressible_nonLinear_2d_benchmark.xml → ...glePhaseThermalConductivity_benchmark.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<CellElementRegion
name="region"
cellBlocks="{ cb }"
materialList="{ fluid, rock_nonLinear, thermalCond }"/>
materialList="{ fluid, rock_linear, thermalCond_nonLinear }"/>
</ElementRegions>

<Mesh>
Expand Down
2 changes: 1 addition & 1 deletion ...hermalCompressible_nonLinear_2d_smoke.xml → ...tSinglePhaseThermalConductivity_smoke.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<CellElementRegion
name="region"
cellBlocks="{ cb }"
materialList="{ fluid, rock_nonLinear, thermalCond }"/>
materialList="{ fluid, rock_linear, thermalCond_nonLinear }"/>
</ElementRegions>

<Mesh>
Expand Down
50 changes: 50 additions & 0 deletions ...glePhaseFlow/thermalCompressible_temperatureDependentVolumetricHeatCapacity_benchmark.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<?xml version="1.0" ?>

<Problem>
<Included>
<File name="./thermalCompressible_2d_base.xml" />
</Included>

<ElementRegions>
<CellElementRegion
name="region"
cellBlocks="{ cb }"
materialList="{ fluid, rock_temperatureDependentVolumetricHeatCapacity, thermalCond_linear }"/>
</ElementRegions>

<Mesh>
<InternalWellbore
name="mesh1"
elementTypes="{ C3D8 }"
radius="{ 0.1, 0.106, 0.133, 1.0 }"
theta="{ 0, 90 }"
zCoords="{ 0, 0.1 }"
nr="{ 3, 10, 50 }"
nt="{ 80 }"
nz="{ 1 }"
trajectory="{ { 0.0, 0.0, 0.0 },
{ 0.0, 0.0, 0.1 } }"
autoSpaceRadialElems="{ 0, 0, 1 }"
cellBlockNames="{ cb }"
/>
</Mesh>

<Events
maxTime="1e5">
<PeriodicEvent
name="outputs"
timeFrequency="1e4"
target="/Outputs/vtkOutput"/>

<PeriodicEvent
name="solverApplications"
maxEventDt="1e3"
target="/Solvers/singleFlow"/>

<!--PeriodicEvent
name="restarts"
timeFrequency="1e5"
target="/Outputs/restartOutput"/-->
</Events>

</Problem>
50 changes: 50 additions & 0 deletions .../singlePhaseFlow/thermalCompressible_temperatureDependentVolumetricHeatCapacity_smoke.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<?xml version="1.0" ?>

<Problem>
<Included>
<File name="./thermalCompressible_2d_base.xml" />
</Included>

<ElementRegions>
<CellElementRegion
name="region"
cellBlocks="{ cb }"
materialList="{ fluid, rock_temperatureDependentVolumetricHeatCapacity, thermalCond_linear }"/>
</ElementRegions>

<Mesh>
<InternalWellbore
name="mesh1"
elementTypes="{ C3D8 }"
radius="{ 0.1, 0.106, 0.133, 1.0 }"
theta="{ 0, 90 }"
zCoords="{ 0, 0.1 }"
nr="{ 3, 10, 50 }"
nt="{ 8 }"
nz="{ 1 }"
trajectory="{ { 0.0, 0.0, 0.0 },
{ 0.0, 0.0, 0.1 } }"
autoSpaceRadialElems="{ 0, 0, 1 }"
cellBlockNames="{ cb }"
/>
</Mesh>

<Events
maxTime="3e3">
<PeriodicEvent
name="outputs"
timeFrequency="1e3"
target="/Outputs/vtkOutput"/>

<PeriodicEvent
name="solverApplications"
maxEventDt="1e3"
target="/Solvers/singleFlow"/>

<PeriodicEvent
name="restarts"
timeFrequency="1e3"
target="/Outputs/restartOutput"/>
</Events>

</Problem>
12 changes: 10 additions & 2 deletions inputFiles/singlePhaseFlow/thermalSinglePhaseFlow.ats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,17 @@ decks = [
check_step=20,
restartcheck_params=RestartcheckParameters(**restartcheck_params)),
TestDeck(
name="thermalCompressible_nonLinear_2d_smoke",
name="thermalCompressible_temperatureDependentVolumetricHeatCapacity_smoke",
description=
'non-linear thermal diffusion around a wellbore)',
'a wellbore problem with temperature dependent volumetric heat capacity)',
partitions=((1, 1, 1), (2, 2, 1)),
restart_step=1,
check_step=2,
restartcheck_params=RestartcheckParameters(**restartcheck_params)),
TestDeck(
name="thermalCompressible_temperatureDependentSinglePhaseThermalConductivity_smoke",
description=
'a wellbore problem with temperature dependent thermal conductivity)',
partitions=((1, 1, 1), (2, 2, 1)),
restart_step=1,
check_step=2,
Expand Down
4 changes: 2 additions & 2 deletions ...iles/thermalSinglePhaseFlowFractures/egsCollab_thermalFlow/egsCollab_thermalFlow_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@
specificHeatCapacity="4.2e6"
referenceInternalEnergy="0.99"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 3.81, 3.81, 3.81 }"/>
defaultThermalConductivityComponents="{ 3.81, 3.81, 3.81 }"/>

<CompressibleSolidParallelPlatesPermeability
name="fractureFilling"
Expand Down
4 changes: 2 additions & 2 deletions inputFiles/thermalSinglePhaseFlowFractures/fractureMatrixThermalFlow_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
specificHeatCapacity="1.672e2"
referenceInternalEnergy="0.001"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 1, 1, 1 }"/>
defaultThermalConductivityComponents="{ 1, 1, 1 }"/>

<CompressibleSolidParallelPlatesPermeability
name="fractureFilling"
Expand Down
4 changes: 2 additions & 2 deletions inputFiles/thermoPoromechanics/ThermoPoroElastic_consolidation_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@
name="rockPerm"
permeabilityComponents="{ 4.0e-9, 4.0e-9, 4.0e-9 }"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 836, 836, 836 }"/>
defaultThermalConductivityComponents="{ 836, 836, 836 }"/>
<!-- SPHINX_PERMEABILITY_CONDUCTIVITY_END -->

</Constitutive>
Expand Down
4 changes: 2 additions & 2 deletions inputFiles/thermoPoromechanicsFractures/ThermoPoroElastic_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
specificHeatCapacity="1.672e2"
referenceInternalEnergy="0.001"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 1, 1, 1 }"/>
defaultThermalConductivityComponents="{ 1, 1, 1 }"/>

<SolidInternalEnergy
name="rockInternalEnergy"
Expand Down
4 changes: 2 additions & 2 deletions inputFiles/thermoPoromechanicsFractures/ThermoPoroElastic_efem-edfm_eggModel_small.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,9 @@
specificHeatCapacity="1.672e2"
referenceInternalEnergy="0.001"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="thermalCond"
thermalConductivityComponents="{ 10, 10, 10 }"/>
defaultThermalConductivityComponents="{ 10, 10, 10 }"/>

<BiotPorosity
name="rockPorosity"
Expand Down
16 changes: 8 additions & 8 deletions inputFiles/wellbore/CasedThermoElasticWellbore_ImperfectInterfaces_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,22 +202,22 @@
<!-- SPHINX_PermeabilityPropertiesEnd -->


<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="casingThermalCond"
thermalConductivityComponents="{ 15, 15, 15 }"/>
defaultThermalConductivityComponents="{ 15, 15, 15 }"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="cementThermalCond"
thermalConductivityComponents="{ 1.0, 1.0, 1.0 }"/>
defaultThermalConductivityComponents="{ 1.0, 1.0, 1.0 }"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="rockThermalCond"
thermalConductivityComponents="{ 1.66, 1.66, 1.66 }"/>
defaultThermalConductivityComponents="{ 1.66, 1.66, 1.66 }"/>

<!-- SPHINX_ContactThermalProperties -->
<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="contactThermalCond"
thermalConductivityComponents="{ 1.0, 1.0, 1.0 }"/>
defaultThermalConductivityComponents="{ 1.0, 1.0, 1.0 }"/>
<!-- SPHINX_ContactThermalPropertiesEnd -->

<!-- SPHINX_FluidProperties -->
Expand Down
12 changes: 6 additions & 6 deletions inputFiles/wellbore/CasedThermoElasticWellbore_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,17 @@
<!-- SPHINX_PermeabilityPropertiesEnd -->

<!-- SPHINX_ThermalProperties -->
<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="casingThermalCond"
thermalConductivityComponents="{ 15, 15, 15 }"/>
defaultThermalConductivityComponents="{ 15, 15, 15 }"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="cementThermalCond"
thermalConductivityComponents="{ 1.0, 1.0, 1.0 }"/>
defaultThermalConductivityComponents="{ 1.0, 1.0, 1.0 }"/>

<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="rockThermalCond"
thermalConductivityComponents="{ 1.66, 1.66, 1.66 }"/>
defaultThermalConductivityComponents="{ 1.66, 1.66, 1.66 }"/>
<!-- SPHINX_ThermalPropertiesEnd -->

<!-- SPHINX_FluidProperties -->
Expand Down
4 changes: 2 additions & 2 deletions inputFiles/wellbore/ThermoPoroElasticWellbore_base.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@
<!-- SPHINX_PermeabilityPropertiesEnd -->

<!-- SPHINX_ThermalProperties -->
<SinglePhaseConstantThermalConductivity
<SinglePhaseThermalConductivity
name="rockThermalCond"
thermalConductivityComponents="{ 6.6, 6.6, 6.6 }"/>
defaultThermalConductivityComponents="{ 6.6, 6.6, 6.6 }"/>
<!-- SPHINX_ThermalPropertiesEnd -->

<!-- SPHINX_FluidProperties -->
Expand Down
Loading
Loading