Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feature/byer3/thermal well #3156
feat: feature/byer3/thermal well #3156
Changes from 66 commits
3c5801c
de5b3da
993296d
7bd1201
825d27d
c94eed6
701bce6
6858b81
8fd8f40
384e29e
064cc07
aee32bc
6323c13
34a2a01
828b009
8b10201
25e3503
aa800e3
c9138c5
5d95d0f
b4983b0
d297111
0ec258e
a489169
420855d
32ae6b9
bea94d5
887192d
b9b6676
99efdea
2b8ca8d
86ed597
4de08c1
7c8fb31
0e2b420
11e6056
dfaa419
f508369
bce0bf9
a1b70ac
b3ed475
e4edc21
352ca5d
574a18e
25fae7f
371eb04
9c7a462
b5b3413
2e1bb1e
dc1faee
561710e
fbf9898
e6db741
109e43f
8963ffa
25d8e2b
eee00a3
11d1d80
c51952f
47eada8
3a70471
d7c6759
5b66e34
127d4cf
0f46cdc
4da9ef7
b711a87
17cc023
720901c
fdeea3a
4cf2106
35cf15b
f1f633b
e659c7c
3162266
988ae2b
dcb533b
7e3619c
72f8895
32d1d28
12e9314
aa71f2a
f5ef324
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this file sits in common it should be a lot more generic IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could move to fluidflow...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to physicsSolvers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to add one with
true
inThermalCompressibleSinglePhaseFluid
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjb-ltk Is this resolved?