chore: add a few comments and small code fixes in addTransmissibilityCouplingPattern for poromechanics with conforming fractures #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryar9534
changed the title
ryar9534
requested review from
rrsettgast,
corbett5,
wrtobin,
CusiniM,
paveltomin,
castelletto1 and
untereiner
as code owners
ryar9534
added
type: bug
paveltomin
approved these changes
Jul 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3250 +/- ##
========================================
Coverage 55.99% 55.99%
========================================
Files 1053 1053
Lines 89157 89157
========================================
Hits 49921 49921
Misses 39236 39236 ☔ View full report in Codecov by Sentry. |
|
@ryar9534 is it good to merge? |
It should be - Matteo and I were considering waiting and including it in the solution to the import bug once we found it (just to avoid rebaselining multiple times) but lets just go ahead and do it. I will handle the rebaseline when the tests complete |
rrsettgast
approved these changes
Aug 10, 2024
|
@ryar9534 This doesn't seem to be passing tests. |
jhuang2601
approved these changes
Aug 16, 2024
CusiniM
reviewed
Aug 16, 2024
src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp
Outdated
Show resolved
Hide resolved
CusiniM
changed the title
rrsettgast
pushed a commit
that referenced
this pull request
Sep 17, 2024
…CouplingPattern for poromechanics with conforming fractures (#3250) --------- Co-authored-by: Ryan ARONSON (X) <[email protected]>
rrsettgast
pushed a commit
that referenced
this pull request
Sep 17, 2024
…CouplingPattern for poromechanics with conforming fractures (#3250) --------- Co-authored-by: Ryan ARONSON (X) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing const and changes a globalIndex to a localIndex, as well as using flow solver discretization name to get stencil.
As it turns out, there was no indexing error.