Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a few comments and small code fixes in addTransmissibilityCouplingPattern for poromechanics with conforming fractures #3250

Merged
merged 19 commits into from
Aug 16, 2024
Merged
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -405,13 +405,13 @@
for( localIndex kf = 0; kf < 2; ++kf )
{
// Set row DOF index
globalIndex const rowIndex = presDofNumber[sei[iconn][1-kf]] - rankOffset;
localIndex const rowIndex = presDofNumber[sei[iconn][kf]] - rankOffset;

Check warning on line 408 in src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp

View check run for this annotation

Codecov / codecov/patch

src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp#L408

Added line #L408 was not covered by tests

if( rowIndex > 0 && rowIndex < pattern.numRows() )
{

// Get fracture, face and region/subregion/element indices (for elements on both sides)
localIndex fractureIndex = sei[iconn][kf];
localIndex const fractureIndex = sei[iconn][kf];

Check warning on line 414 in src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp

View check run for this annotation

Codecov / codecov/patch

src/coreComponents/physicsSolvers/multiphysics/SinglePhasePoromechanicsConformingFractures.cpp#L414

Added line #L414 was not covered by tests

// Get the number of nodes
localIndex const numNodesPerFace = faceToNodeMap.sizeOfArray( elemsToFaces[fractureIndex][0] );
Expand Down
Loading