-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify build documents for problems from JOSS reviewers #3258
Modify build documents for problems from JOSS reviewers #3258
Conversation
@timokoch The result of the
|
ld: warning: -commons use_dylibs is no longer supported, using error treatment instead | ||
ld: file not found: @rpath/libquadmath.0.dylib for architecture arm64 | ||
clang: error: linker command failed with exit code 1 (use -v to see invocation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't think I get this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really? we are going to have to compare configurations tomorrow. You have an M1
or an M2
? I have this error on both M1
and M2
. Are you on Sonoma (MacOS 14.6)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do get the linker error (M1 / macOS 13 / apple clang 14)
On macOS 13 with apple clang 14, you need at least openMPI 5.0.4 (although I only tested with 5.1) which can be installed by brew install open-mpi --HEAD. |
@timokoch Are you able to build now? |
|
||
.. code-block:: | ||
|
||
brew install bison cmake gfortran git-lfs open-mpi lapack python3 ninja m4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like ninja, but it isn't necessary I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary, but for geos
, ninja
does compile much faster than make
|
||
.. code-block:: | ||
|
||
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe replace by link to homebrew in case this changes as some point, and then there is also other information on how to setup homebrew.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes...good idea
.. code-block:: | ||
|
||
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" | ||
(echo; echo 'eval "$(/opt/homebrew/bin/brew shellenv)"') >> /Users/settgast1/.zprofile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Don't really like my PATH being modified when I'm installing some package. Also it assumes you are using zsh which should be mentioned (for example I don't).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I have this line in my shell environment too but I know I added it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the recommended path modification from home-brew, but it is specific to my shell. I will better document this and generalize it
ld: warning: -commons use_dylibs is no longer supported, using error treatment instead | ||
ld: file not found: @rpath/libquadmath.0.dylib for architecture arm64 | ||
clang: error: linker command failed with exit code 1 (use -v to see invocation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do get the linker error (M1 / macOS 13 / apple clang 14)
Yes I can build the geosx target now, thanks! |
…tion/updateBuildDocs
fba859c
into
docs/cusini/joss-review-docs-suggetions
* Modify build documents for problems from JOSS reviewers (#3258) * add Apple MacOS build doc * quick-start-template.cmake * Update host-configs/quick-start-template.cmake * add CODE_OF_CONDUCT and CONTRIBUTING file * fix doxygen links in sphinx docs * Update src/docs/sphinx/QuickStart.rst * Doxygen for SolverBase * Update Example.rst (#3315) * add frontier scaling to documentation * add the entire physicsSolver directory to the readthedocs doxygen * add card on main documentation page for submitting issues * fix a couple of typos * Add instructions, postprocess script, and figures to WellboreECP problem --------- Co-authored-by: Randolph Settgast <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]> Co-authored-by: Victor A. P. Magri <[email protected]>
* Modify build documents for problems from JOSS reviewers (#3258) * add Apple MacOS build doc * quick-start-template.cmake * Update host-configs/quick-start-template.cmake * add CODE_OF_CONDUCT and CONTRIBUTING file * fix doxygen links in sphinx docs * Update src/docs/sphinx/QuickStart.rst * Doxygen for SolverBase * Update Example.rst (#3315) * add frontier scaling to documentation * add the entire physicsSolver directory to the readthedocs doxygen * add card on main documentation page for submitting issues * fix a couple of typos * Add instructions, postprocess script, and figures to WellboreECP problem --------- Co-authored-by: Randolph Settgast <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]> Co-authored-by: Victor A. P. Magri <[email protected]>
* Modify build documents for problems from JOSS reviewers (#3258) * add Apple MacOS build doc * quick-start-template.cmake * Update host-configs/quick-start-template.cmake * add CODE_OF_CONDUCT and CONTRIBUTING file * fix doxygen links in sphinx docs * Update src/docs/sphinx/QuickStart.rst * Doxygen for SolverBase * Update Example.rst (#3315) * add frontier scaling to documentation * add the entire physicsSolver directory to the readthedocs doxygen * add card on main documentation page for submitting issues * fix a couple of typos * Add instructions, postprocess script, and figures to WellboreECP problem --------- Co-authored-by: Randolph Settgast <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]> Co-authored-by: Victor A. P. Magri <[email protected]>
The JOSS paper reviewers are having problems building (#3256). This PR aims to provide fixes and/or better documentation for their cases.