Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup setMGRStrategy a bit #3386

Merged
merged 13 commits into from
Oct 31, 2024
Merged

refactor: cleanup setMGRStrategy a bit #3386

merged 13 commits into from
Oct 31, 2024

Conversation

paveltomin
Copy link
Contributor

@paveltomin paveltomin commented Oct 3, 2024 •
edited
Loading

should go after #3383

@paveltomin paveltomin requested a review from victorapm October 3, 2024 23:02
@paveltomin paveltomin self-assigned this Oct 3, 2024
victorapm
victorapm approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@victorapm victorapm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@paveltomin paveltomin mentioned this pull request Oct 4, 2024
Merged
@paveltomin paveltomin changed the base branch from develop to pt/wells-seq-poromech-init October 4, 2024 22:17
@paveltomin paveltomin removed the request for review from andrea-borio October 4, 2024 22:20
castelletto1
castelletto1 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@castelletto1 castelletto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@jhuang2601 jhuang2601 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Oct 29, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 7.81250% with 118 lines in your changes missing coverage. Please review.

Please upload report for BASE (pt/wells-seq-poromech-init@1c67dc6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...sSolvers/contact/SolidMechanicsLagrangeContact.cpp 0.00% 13 Missing ⚠️
...olvers/contact/SolidMechanicsEmbeddedFractures.cpp 0.00% 12 Missing ⚠️
...csSolvers/multiphysics/MultiphasePoromechanics.cpp 0.00% 12 Missing ⚠️
...sSolvers/multiphysics/SinglePhasePoromechanics.cpp 0.00% 12 Missing ⚠️
...ysics/CompositionalMultiphaseReservoirAndWells.cpp 23.07% 10 Missing ⚠️
...hysicsSolvers/multiphysics/HydrofractureSolver.cpp 0.00% 10 Missing ⚠️
...vers/multiphysics/SinglePhaseReservoirAndWells.cpp 23.07% 10 Missing ⚠️
...cs/SinglePhasePoromechanicsConformingFractures.cpp 0.00% 9 Missing ⚠️
...sics/SinglePhasePoromechanicsEmbeddedFractures.cpp 0.00% 9 Missing ⚠️
...vers/multiphysics/CoupledReservoirAndWellsBase.hpp 44.44% 5 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@                      Coverage Diff                      @@
##             pt/wells-seq-poromech-init    #3386   +/-   ##
=============================================================
  Coverage                              ?   56.75%           
=============================================================
  Files                                 ?     1076           
  Lines                                 ?    95805           
  Branches                              ?        0           
=============================================================
  Hits                                  ?    54371           
  Misses                                ?    41434           
  Partials                              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhuang2601 jhuang2601 added the flag: no rebaseline Does not require rebaseline label Oct 30, 2024
@CusiniM CusiniM merged commit dd09e8e into pt/wells-seq-poromech-init Oct 31, 2024
25 checks passed
@CusiniM CusiniM deleted the pt/set-mgr-strategy branch October 31, 2024 23:28
paveltomin added a commit that referenced this pull request Nov 1, 2024
@paveltomin
Revert "refactor: cleanup setMGRStrategy a bit (#3386)"
79ca71b 
This reverts commit dd09e8e.
@paveltomin paveltomin mentioned this pull request Nov 1, 2024
Merged
paveltomin added a commit that referenced this pull request Nov 1, 2024
@paveltomin
Revert "refactor: cleanup setMGRStrategy a bit (#3386)" (#3420)
3ee47da 
This reverts commit dd09e8e.
@paveltomin paveltomin restored the pt/set-mgr-strategy branch November 1, 2024 16:31
@paveltomin
Copy link
Contributor Author

reopened here #3422

@paveltomin paveltomin mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@victorapm victorapm victorapm approved these changes

@matteofrigo5 matteofrigo5 matteofrigo5 approved these changes

@castelletto1 castelletto1 castelletto1 approved these changes

@CusiniM CusiniM Awaiting requested review from CusiniM

@rrsettgast rrsettgast Awaiting requested review from rrsettgast

Assignees

@paveltomin paveltomin

Labels
ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paveltomin @castelletto1 @matteofrigo5 @victorapm @jhuang2601 @CusiniM