Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
geos::string_array
type output asint8 array
, we cannot really diagnose changing text data in the integrated tests.As a temporary solution, I propose to add a character comparison output to the current one.
string_array
could have been only reordered.As an exemple, for my PR about extending the
cellBlocks
input (which order thecellBlock
names alphabetically), we would have this message in thecompositionalMultiphaseFlow/deadoil_3ph_staircase_3d_01
test logs:And this is what I propose:
The "substrings reordering detected" note helps the reader to know that the substrings are only reordered.