Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygeosx testing #259

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pygeosx testing #259

wants to merge 3 commits into from

Conversation

bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Feb 8, 2024

This PR installs additional pygeosx dependencies to run pygeosx tests on gcc ubuntu images.

Related to GEOS-DEV/GEOS#2981
Related to GEOS-DEV/LvArray#318

@bmhan12 bmhan12 self-assigned this Feb 8, 2024
@bmhan12 bmhan12 changed the title Pygeosx Testing pygeosx testing Feb 8, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from b18ddc2 to 46e3afe Compare February 22, 2024 17:41
@bmhan12 bmhan12 marked this pull request as ready for review February 29, 2024 22:08
with:
submodules: true
lfs: true

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@untereiner do you think a dependabot would be useful here as well?
If so, do you mind setting one up?

@@ -120,7 +121,15 @@ RUN apt-get install -y --no-install-recommends \
libxml2-utils \
git \
ghostscript \
ninja-build
ninja-build \
python3 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of having python hopping in our builds, even for non pygeosx builds... I guess it is what it is.

@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 3c38f90 to 349faac Compare March 20, 2024 22:52
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 6114d26 to 0af624a Compare July 18, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants