-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygeosx testing #2981
base: develop
Are you sure you want to change the base?
pygeosx testing #2981
Conversation
c77049b
to
a6d41a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2981 +/- ##
========================================
Coverage 53.25% 53.25%
========================================
Files 989 989
Lines 83558 83558
========================================
Hits 44495 44495
Misses 39063 39063 ☔ View full report in Codecov by Sentry. |
5abaa1a
to
33e7712
Compare
33e7712
to
c72ba06
Compare
.github/workflows/build_and_test.yml
Outdated
|
||
# pygeosx testing | ||
ENABLE_PYGEOSX=${{ inputs.ENABLE_PYGEOSX }} | ||
docker_args+=(-e ENABLE_PYGEOSX=${ENABLE_PYGEOSX:-OFF}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to reduce the number of environment variables and favor direct CLI options.
Do you think we could have the shell script have some kind of --pygeosx
flag that would trigger pygeos
?
That would make a long list of options indeed, but in the end, it helps us to be more explicit about what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could have the shell script have some kind of --pygeosx flag that would trigger pygeos?
Yes, adjusted the script to pass a -DENABLE_PYGEOSX=ON
option instead of setting an environment variable.
eb9eebc
to
ae87421
Compare
Should |
439b937
to
2ff8816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
f892168
to
fb07769
Compare
This PR adds pygeosx unit tests to Github Actions, specfically the gcc ubuntu images.
Related to GEOS-DEV/thirdPartyLibs#259
Related to GEOS-DEV/LvArray#318