-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-1939, GPII-2395 - Device Reporter reports screen resolutions #95
base: master
Are you sure you want to change the base?
Conversation
- Modified the node XRandR add-on to return the available screen resolutions as an array of JSON objects, rather than strings. - Refactored the XRandR bridge code into a fluid component. - Updated the unit tests in light of the above.
Modified "screen-resolution" payload to now contain: - "current-resolution" (width and height) - "available-resolution" (array of widths and heights).
Modified to be analagous to the Windows display settings handler.
Remvoed {that} parameter from get() and set() functions.
Added machinery for providing a Linux/GNOME Platform Reporter that uses the XRandR display settings handler to report all screen resolutions. Note: includes code from pull request for GPII-2395, "XRandR bridge should report all available screen resolutions".
Fixed description in package.json.
Fixed bug so that GPII finds the Linux context platform reporter.
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
ok to test |
Hi @amatas, I typed "ok to test" above a couple of hours ago, but the checks have not started yet. Any ideas? |
@klown you weren't in the list of the allowed people to trigger the jobs. I've added you. |
ok to test |
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
CI is failing due to missing changes from #94. We need to either merge that PR or revert the CI configuration. |
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
ok to test |
CI job passed. |
CI job failed: https://ci.gpii.net/job/linux-tests/108/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/109/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/110/ |
ok to test |
ok to test |
CI job passed: https://ci.gpii.net/job/linux-tests/129/ |
ok to test |
CI job passed: https://ci.gpii.net/job/linux-tests/134/ |
CI job passed: https://ci.gpii.net/job/linux-tests/136/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/138/ |
CI job passed: https://ci.gpii.net/job/linux-tests/142/ |
ok to test |
CI job passed: https://ci.gpii.net/job/linux-tests/144/ |
test this please |
CI job failed: https://ci.gpii.net/job/linux-tests/145/ |
test this please |
CI job failed: https://ci.gpii.net/job/linux-tests/146/ |
test this please |
CI job passed: https://ci.gpii.net/job/linux-tests/147/ |
ok to test |
CI job failed: https://ci.gpii.net/job/linux-tests/155/ |
Modified to reference the version of universal just prior to incorporating Kasper's GPII-1230 code, which introduced functionality not yet implemented in the linux repository.
CI job passed: https://ci.gpii.net/job/linux-tests/157/ |
Includes updating to latest master branch.
CI job passed: https://ci.gpii.net/job/linux-tests/161/ |
Linux specific code for the Device Reporter such that it reports screen resoulutions.