Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rod-plane contact examples + Continuum Snake With Lifting Wave example #317

Merged
merged 11 commits into from
Dec 5, 2023
Merged

Refactor rod-plane contact examples + Continuum Snake With Lifting Wave example #317

merged 11 commits into from
Dec 5, 2023

Conversation

Ali-7800
Copy link
Collaborator

Sixth contact module PR mentioned in Issue
This PR includes:

  • Refactored examples that use AnisotropicFrictionalPlane to use RodPlaneContactWithAnisotropicFriction instead
  • Added new example: ContinuumSnakeWithLiftingWaveCase, to replicate the results from X. Zhang et. al. Nat. Comm. 2021. Related to this Issue

@Ali-7800 Ali-7800 added enhancement New feature or request prio:medium Priority level: medium labels Nov 15, 2023
@Ali-7800 Ali-7800 requested review from skim0119 and sy-cui November 15, 2023 02:09
@Ali-7800 Ali-7800 self-assigned this Nov 15, 2023
@Ali-7800 Ali-7800 removed the request for review from bhosale2 November 15, 2023 02:11
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1da4dbc) 93.46% compared to head (1273c13) 93.46%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##           update-0.3.2     #317   +/-   ##
=============================================
  Coverage         93.46%   93.46%           
=============================================
  Files                51       51           
  Lines              3183     3183           
  Branches            348      348           
=============================================
  Hits               2975     2975           
  Misses              158      158           
  Partials             50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

armantekinalp
armantekinalp requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Can you also add videos for snakes and plots for validation cases for reference.

examples/ContinuumSnakeWithLiftingWaveCase/continuum_snake_with_lifting_wave.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/continuum_snake_with_lifting_wave.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/continuum_snake_with_lifting_wave.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
@Ali-7800
Copy link
Collaborator Author

Ali-7800 commented Nov 28, 2023 •
edited
Loading

Examples videos/plots:

MuscularSnake

2D_xy_muscular_snake.mp4

muscular_snake_velocity

Axial Friction

axial_friction

rolling friction torque

rolling_friction_torque

rolling friction on inclined plane

rolling_friction_on_inclined_plane

rolling friction initial velocity

rolling_friction_initial_velocity

Continuum snake with lifting wave

continuum_snake_with_lifting_wave.mp4

Continuum Snake

continuum_snake.mp4

![continuum_snake_velocity](https://github.com/GazzolaLab/PyElastica/assets/47090295/f403db0e-576a-4461-ac49-a6fd273e99e

continuum_snake_curvature
5)

armantekinalp
armantekinalp approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just two comments.

examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
@armantekinalp
Copy link
Contributor

@skim0119 and @sy-cui can you briefly check and approve

sy-cui
sy-cui reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@sy-cui sy-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

examples/ContinuumSnakeWithLiftingWaveCase/continuum_snake_with_lifting_wave.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_contact.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
examples/ContinuumSnakeWithLiftingWaveCase/snake_forcing.py Outdated Show resolved Hide resolved
@Ali-7800 Ali-7800 requested a review from sy-cui December 3, 2023 23:53
sy-cui
sy-cui approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@sy-cui sy-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skim0119
skim0119 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end 👍

armantekinalp
armantekinalp approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armantekinalp
Copy link
Contributor

@Ali-7800 you can merge whenever you want

@Ali-7800 Ali-7800 merged commit c2a641e into GazzolaLab:update-0.3.2 Dec 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@sy-cui sy-cui sy-cui approved these changes

@skim0119 skim0119 skim0119 approved these changes

Assignees

@Ali-7800 Ali-7800

Labels
enhancement New feature or request prio:medium Priority level: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ali-7800 @codecov-commenter @armantekinalp @skim0119 @sy-cui