-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anymal robot preview in MeshCat (Tree.js) #134
Conversation
I checked that this works in Meshcat; however, I am unable to do so in GV and RVIZ (PC with apple chip). |
It seems the mesh was not compatible with Tree.js. MeshLab has been used to fix the issue.
I rebased to avoid the conflict |
So it works @nim65s ? |
what ? the real robot really has those violet stuff ? It looks like an artifact that @jcarpent version is fixing for me. Here is another "before" view: |
Sorry I am not sure what you meant. Instead I meant, the colours in the motors and fan are gray. Furthermore, there are plates or covers that are blue. However, answering your questions. Yes, the ANYmal robot looks pretty much that the original picture. These texture were added by ANYbotics. |
Honestly, I don't know how to recover from this issue. The current anymal robot cannot be displayed in Meshcat. The fix that we suggest here fixes this issue, yet with some minor degradation. Could we then merge this PR and open a pending issue concerning the fix for retrieving the blue colors? |
We use this model in Rviz as well, and for many of us, we wish to still have good quality videos, e.g., Generally, I don't believe it is a good development strategy to degrade others, for the sake of having extra features. Additionally, it is not clear (at least for me) why we need to do this here, instead of solving the issue in Avoiding long-to-release solutions (that could be the case in extending All these are patches over patches, but it could be faster to release. I understand your frustration in having this merge, however, I am trying to play the role of devil's advocate :) |
Do you know how to do that? Are you willing to do that? |
No, I don't. |
If none of us has the time to get a version of this mesh that works well enough everwhere, we can duplicate it, and let the user choose. But I'll try to get a more clear look at this Tomorrow, and open issues on Tree.js and/or the original anymal repo if needed. |
Can we use obj for MeshCat? |
yes |
I am looking into a fix for this. I have a workaround that detects and "fixes" broken DAEs on the fly rather than omitting them from Meshcat/THREE.js. It requires some more testing before upstreaming |
I've got a workaround that allows loading the current mesh in the repository in Meshcat, see upstream PR: meshcat-dev/meshcat#139 Using this, we get the following: Let's see if the upstream PR gets merged. And with some extra changes to meshcat-python that I am working on we could get texture support: Alternatively, I have a new mesh that bakes in the colours and displays correctly but it's significantly larger so I won't commit it. |
I'll close this PR. Feel free to re-open if required, @jcarpent! |
No description provided.