Fix reaction author's view with shrinked reaction images in iOS 18 #3568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-652/[uikit]-reaction-icons-have-invalid-size-in-reactions-overlay
🎯 Goal
Fixes reaction author's view with shrinked reaction images introduced on iOS 18.
We did not spot the bug when re-recording iOS 18 snapshots here: #3509
🛠 Implementation
The root of the issue is that on iOS 18, the
Button.image.size
isnil
in theChatMessageReactionItemView.intrinsicContentSize
when it is inside the reaction author cell view. The best way I found to fix the issue without breaking changes is to provide a default size instead ofsuper.intrinsicContentSize
in case the image does not have any size.🧪 Manual Testing Notes
It is not necessary to do manual tests since it is covered by snapshots.
☑️ Contributor Checklist
docs-content
repo