sim: fix pin parsing mismatch #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanda-phi
requested changes
Nov 16, 2023
|
Also, nit on commit messages: mismatch not missmatch. |
anuejn
force-pushed
the
sim-pin-parsing
branch
from
c732d2c to
6935487
Compare
whitequark
approved these changes
Nov 16, 2023
|
This has a merge conflict now. |
anuejn
force-pushed
the
sim-pin-parsing
branch
from
6935487 to
13ba3f3
Compare
wanda-phi
requested changes
Nov 16, 2023
anuejn
force-pushed
the
sim-pin-parsing
branch
2 times, most recently
from
d30a49a to
2440975
Compare
|
sorry for the amount of wrong code, I am not having a very good morning |
wanda-phi
requested changes
Nov 16, 2023
anuejn
force-pushed
the
sim-pin-parsing
branch
2 times, most recently
from
2882966 to
2735397
Compare
wanda-phi
requested changes
Nov 16, 2023
Co-authored-by: Wanda <[email protected]>
wanda-phi
force-pushed
the
sim-pin-parsing
branch
from
2735397 to
47b6c68
Compare
wanda-phi
approved these changes
Nov 16, 2023
Merged
via the queue into
GlasgowEmbedded:main
with commit Nov 16, 2023
b6e1cc6
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.