Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent shell redirection when installing packages #1478

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Oct 24, 2023

Description

When specifying a version constraint with zypper, the lack of quotes can cause shell redirection instead.

Related issue

b/307553822

How has this been tested?

Will let presubmits run.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Copy link
Contributor

@martijnvans martijnvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go/shell-style#quoting says to use single quotes unless you want (or can tolerate, lol) substitutions. Up to you whether you care enough to change that.

@jefferbrecht jefferbrecht force-pushed the jefferbrecht-sles12-bison branch from b758a40 to 261b905 Compare October 24, 2023 20:50
@jefferbrecht
Copy link
Member Author

go/shell-style#quoting says to use single quotes unless you want (or can tolerate, lol) substitutions. Up to you whether you care enough to change that.

Good point, changed to single quotes.

@jefferbrecht
Copy link
Member Author

Doesn't appear to fix the SLES 12 build after all but I'll merge this anyway just in case. We can do a separate PR to fix the issue with the bison repo not getting added correctly.

@jefferbrecht jefferbrecht merged commit 20fdec6 into master Oct 24, 2023
6 checks passed
@jefferbrecht jefferbrecht deleted the jefferbrecht-sles12-bison branch October 24, 2023 21:40
@igorpeshansky igorpeshansky mentioned this pull request Oct 24, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants