Add getParamType function to handle ROS message type mapping #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getParamType function has been added to correctly map ROS message types to their corresponding TypeScript array types when applicable. This function ensures that array types like 'Float32Array' or 'Uint16Array' are correctly recognized and handled, addressing the issue where ros-typescript -gen would always convert these fields to 'number'.
turtle-operator
approved these changes
Apr 16, 2024
|
Hi @MrBlenny, Can you please review this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The getParamType function incorrectly maps some ROS message types to 'number' instead of their corresponding array types like 'Float32Array' or 'Uint16Array'. Additionally, ros-typescript -gen always converts these fields to 'number'.
What is the new behavior?
The getParamType function has been added to correctly map ROS message types to their corresponding TypeScript array types when applicable. This ensures that array types like 'Float32Array' or 'Uint16Array' are correctly recognized and handled. The issue with ros-typescript -gen converting these fields to 'number' has been addressed.
Other information: