Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make procedure able to return output #3201

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 19, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Make procedure able to return output

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3200

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6320590) 85.81% compared to head (0c21aa5) 85.33%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
- Coverage   85.81%   85.33%   -0.48%     
==========================================
  Files         832      833       +1     
  Lines      136308   136817     +509     
==========================================
- Hits       116967   116750     -217     
- Misses      19341    20067     +726     

@WenyXu WenyXu force-pushed the feat/procedure-output branch from bfee22e to 0c21aa5 Compare January 19, 2024 08:02
@fengjiachun fengjiachun mentioned this pull request Jan 19, 2024
3 tasks
@fengjiachun
Copy link
Collaborator

@evenyag PTAL

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Jan 21, 2024
Merged via the queue into GreptimeTeam:main with commit 4278c85 Jan 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants