-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: $TARGET_BIN not found when docker run the image #3297
Conversation
Seems to be a problem with this pr:#3254 |
It’s not a good solution to revert the original PR without finding out the root cause of why run image failed. From the logs, I guess maybe the root cause should be TAGETBIN_BIN which it only works in build-time. IMO, the right solution is to add ENV instruction to inject the TARGET_BIN to envrionment. |
I try to using ENV set TARGET_BIN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MichaelScofield PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I updated the PR descirption for the background. You can add the necessary info in the PR description for the next time :D
Thank @tisonkun |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This fixes #3298
Start the latest version of the greptime docker image and have an error:
This is related to moby/moby#18492.
Checklist
Refer to a related PR or issue link (optional)