Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $TARGET_BIN not found when docker run the image #3297

Merged
merged 7 commits into from
Feb 15, 2024
Merged

fix: $TARGET_BIN not found when docker run the image #3297

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84c531b
fix: TARGET_BIN path
daviderli614 Feb 8, 2024
4ff3aa2
chore: return available versions
daviderli614 Feb 8, 2024
ecd676b
refactor: Use ENV instead of ARG in ci dockerfile
daviderli614 Feb 9, 2024
0daa30f
chore: add TARGET_BIN ENV pass to ENTRYPOINT
daviderli614 Feb 12, 2024
c7aa8c5
chore: add TARGET_BIN ENV pass to ENTRYPOINT
daviderli614 Feb 12, 2024
be2a63d
chore: update entrypoint
daviderli614 Feb 15, 2024
50e7a69
chore: update entrypoint
daviderli614 Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docker/ci/centos/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
FROM centos:7

ENV TARGET_BIN=greptime
daviderli614 marked this conversation as resolved.
Show resolved Hide resolved

RUN yum install -y epel-release \
openssl \
openssl-devel \
Expand All @@ -9,8 +11,8 @@ RUN yum install -y epel-release \

ARG TARGETARCH

ADD $TARGETARCH/greptime /greptime/bin/
ADD $TARGETARCH/$TARGET_BIN /greptime/bin/

ENV PATH /greptime/bin/:$PATH

ENTRYPOINT ["greptime"]
ENTRYPOINT ["$TARGET_BIN"]
2 changes: 1 addition & 1 deletion docker/ci/ubuntu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ FROM ubuntu:22.04
ARG DOCKER_BUILD_ROOT=.
# The binary name of GreptimeDB executable.
# Defaults to "greptime", but sometimes in other projects it might be different.
ARG TARGET_BIN=greptime
ENV TARGET_BIN=greptime
daviderli614 marked this conversation as resolved.
Show resolved Hide resolved

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
ca-certificates \
Expand Down
Loading