feat: impl Display for Statement

[irenjj]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3646

What's changed and what's your intention?

Implement Display for Statement.

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR does not require documentation updates.

[irenjj]

hi @tisonkun , I've finished the main logic. Could you please help check if there are any issues? Afterwards, I will add tests based on this.

[tisonkun]

Thank you! This patch goes in the good direction. Comments inline.

[tisonkun]

Rest LGTM. You can start to write test. Thank you!

[codecov]

Codecov Report

Attention: Patch coverage is 82.29028% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 85.24%. Comparing base (42e7403) to head (a7592a7).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3744      +/-   ##
==========================================
- Coverage   85.59%   85.24%   -0.36%     
==========================================
  Files         947      947              
  Lines      160612   161309     +697     
==========================================
+ Hits       137482   137510      +28     
- Misses      23130    23799     +669     

[tisonkun]

I'll give this patch another round tomorrow, and I suggest you revise it once more with this comment b24d334#r1576504197 in consideration.

[tisonkun]

I push a commit to resolve most of the comments above. Now the remaining part is:

• create.rs
• copy.rs

I'll give another round tomorrow.

[tisonkun]

cc @killme2008 @MichaelScofield in the follow-up we'd change the SQL logging logics with these Display implementations:

                        Err(e) => {
                            let redacted = sql::util::redact_sql_secrets(query.as_ref());
                            if e.status_code().should_log_error() {
                                error!(e; "Failed to execute query: {redacted}");
                            } else {
                                debug!("Failed to execute query: {redacted}, {e}");
                            }

                            results.push(Err(e));
                            break;
                        }

to

                        Err(e) => {
                            if e.status_code().should_log_error() {
                                error!(e; "Failed to execute query: {stmt}");
                            } else {
                                debug!("Failed to execute query: {stmt}, {e}");
                            }

                            results.push(Err(e));
                            break;

see #3646 for more details.

[killme2008]

Fantastic effort and dedication! Many thanks! I've included some suggestions for your consideration. Please review them. @irenjj

[killme2008]

LGTM