-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(index-cache): abstract IndexCache
to be shared by multi types of indexes
#5219
feat(index-cache): abstract IndexCache
to be shared by multi types of indexes
#5219
Conversation
…of indexes Signed-off-by: Zhenchi <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- src/mito2/src/sst/index/inverted_index/applier/builder.rs: Evaluated as low risk
- src/index/src/inverted_index/format/reader/blob.rs: Evaluated as low risk
- src/mito2/src/sst/index/inverted_index/creator.rs: Evaluated as low risk
Signed-off-by: Zhenchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5219 +/- ##
==========================================
- Coverage 84.08% 83.85% -0.24%
==========================================
Files 1184 1185 +1
Lines 219872 219911 +39
==========================================
- Hits 184889 184411 -478
- Misses 34983 35500 +517 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5176
What's changed and what's your intention?
that
bloom_filter
andinverted_index
can easily reuse the struct.PR Checklist
Please convert it to a draft if some of the following conditions are not met.