Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index-cache): abstract IndexCache to be shared by multi types of indexes #5219

Merged
merged 6 commits into from
Dec 24, 2024
Merged

feat(index-cache): abstract IndexCache to be shared by multi types of indexes #5219

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
992e75a
feat(index-cache): abstract `IndexCache` to be shared by multi types …
zhongzc Dec 23, 2024
b99ddb6
fix typo
zhongzc Dec 23, 2024
8f5aa18
fix: remove added label
zhongzc Dec 24, 2024
29853c0
refactor: simplify cached reader impl
zhongzc Dec 24, 2024
12a658d
Merge remote-tracking branch 'origin/main' into zhongzc/index-cache-r…
zhongzc Dec 24, 2024
1eb73ec
rename func
zhongzc Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index/src/inverted_index/format/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ mod footer;
/// InvertedIndexReader defines an asynchronous reader of inverted index data
#[mockall::automock]
#[async_trait]
pub trait InvertedIndexReader: Send {
pub trait InvertedIndexReader: Send + Sync {
/// Seeks to given offset and reads data with exact size as provided.
async fn range_read(&mut self, offset: u64, size: u32) -> Result<Vec<u8>>;

Expand Down
2 changes: 1 addition & 1 deletion src/index/src/inverted_index/format/reader/blob.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ impl<R> InvertedIndexBlobReader<R> {
}

#[async_trait]
impl<R: RangeReader> InvertedIndexReader for InvertedIndexBlobReader<R> {
impl<R: RangeReader + Sync> InvertedIndexReader for InvertedIndexBlobReader<R> {
async fn range_read(&mut self, offset: u64, size: u32) -> Result<Vec<u8>> {
let buf = self
.source
Expand Down
2 changes: 1 addition & 1 deletion src/mito2/src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ use store_api::storage::{ConcreteDataType, RegionId, TimeSeriesRowSelector};

use crate::cache::cache_size::parquet_meta_size;
use crate::cache::file_cache::{FileType, IndexKey};
use crate::cache::index::{InvertedIndexCache, InvertedIndexCacheRef};
use crate::cache::index::inverted_index::{InvertedIndexCache, InvertedIndexCacheRef};
use crate::cache::write_cache::WriteCacheRef;
use crate::metrics::{CACHE_BYTES, CACHE_EVICTION, CACHE_HIT, CACHE_MISS};
use crate::read::Batch;
Expand Down
Loading
Loading