-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust index cache page size #5267
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: according to my experience, 64KiB may be more suitable than 128KiB
@CookiePieWw Please fix the unit test
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5267 +/- ##
==========================================
- Coverage 84.06% 83.82% -0.24%
==========================================
Files 1199 1199
Lines 224236 224316 +80
==========================================
- Hits 188507 188038 -469
- Misses 35729 36278 +549 |
* refactor: adjust index cache page size * fix: wrong docs * Update config/datanode.example.toml * Update config/config.md * Update config/config.md * chore: adjust to 64KiB * Apply suggestions from code review
* refactor: adjust index cache page size * fix: wrong docs * Update config/datanode.example.toml * Update config/config.md * Update config/config.md * chore: adjust to 64KiB * Apply suggestions from code review
* refactor: adjust index cache page size * fix: wrong docs * Update config/datanode.example.toml * Update config/config.md * Update config/config.md * chore: adjust to 64KiB * Apply suggestions from code review
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As title. IO size of inverted index content is relatively small, usually single fst/bitmap. With 8MB page size, cache miss is expensive.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.