-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme #161
docs: update readme #161
Conversation
WalkthroughThe recent updates enhance the deployment documentation for the GreptimeDB cluster, particularly regarding OCI artifacts and CRD management. New sections clarify usage, improve accessibility through updated commands, and emphasize data safety during uninstallation. A minor Helm chart version bump indicates ongoing improvements while maintaining backward compatibility, ensuring users benefit from clearer instructions and better functionality. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- README.md (5 hunks)
- charts/greptimedb-operator/Chart.yaml (1 hunks)
- charts/greptimedb-operator/README.md (3 hunks)
- charts/greptimedb-operator/README.md.gotmpl (2 hunks)
Files skipped from review due to trivial changes (1)
- charts/greptimedb-operator/Chart.yaml
Additional context used
LanguageTool
README.md
[uncategorized] ~151-~151: Possible missing comma found.
Context: ...default** after uninstalling greptimedb-operator unless you use--set crds.keep=false
....(AI_HYDRA_LEO_MISSING_COMMA)
Additional comments not posted (10)
charts/greptimedb-operator/README.md.gotmpl (3)
42-46
: Clear uninstallation instructions.The new "How to Uninstall" section provides clear and concise instructions for uninstalling the greptimedb-operator.
Line range hint
48-82
: Improved CRDs management documentation.The restructuring and additional details in the "CRDs Management" section improve clarity and usability for managing CRDs.
Line range hint
82-87
: Clear instructions for updating CRDs in the chart.The new section provides clear and concise instructions for updating CRDs in the chart.
README.md (4)
28-45
: Clear instructions for using OCI artifacts.The new "OCI Artifacts" section provides clear and concise instructions for using OCI artifacts without adding a chart repository.
115-123
: Enhancedkubectl port-forward
instructions.The updated instructions for
kubectl port-forward
enhance accessibility and flexibility for accessing the GreptimeDB cluster.
151-153
: Clarified CRD uninstallation instructions.The clarification that CRDs are not deleted by default helps prevent accidental data loss and informs users about manual CRD deletion.
Tools
LanguageTool
[uncategorized] ~151-~151: Possible missing comma found.
Context: ...default** after uninstalling greptimedb-operator unless you use--set crds.keep=false
....(AI_HYDRA_LEO_MISSING_COMMA)
151-151
: No change needed.The sentence is clear and does not require a comma. The LanguageTool suggestion is a false positive.
Tools
LanguageTool
[uncategorized] ~151-~151: Possible missing comma found.
Context: ...default** after uninstalling greptimedb-operator unless you use--set crds.keep=false
....(AI_HYDRA_LEO_MISSING_COMMA)
charts/greptimedb-operator/README.md (3)
5-5
: Version update to 0.2.3.The version number has been updated to
0.2.3
, indicating ongoing improvements.
43-47
: Clear uninstallation instructions.The new "How to Uninstall" section provides clear and concise instructions for uninstalling the greptimedb-operator.
Line range hint
49-83
: Improved CRDs management documentation.The restructuring and additional details in the "CRDs Management" section improve clarity and usability for managing CRDs.
Summary by CodeRabbit
New Features
greptimedb-operator
without deleting CRDs by default.Documentation