Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(greptimedb-cluster): incorrect .vector.resources field #201

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Nov 19, 2024

Summary by CodeRabbit

  • New Features
    • Updated logging configuration to include slow query logging with customizable threshold and sample ratio.
  • Improvements
    • Enhanced resource specification handling for the monitoring vector component.
  • Version Updates
    • Incremented version number from 0.2.32 to 0.2.33 in both the Helm chart and README.

Copy link
Contributor

coderabbitai bot commented Nov 19, 2024

Walkthrough

The changes in this pull request primarily involve updates to the greptimedb-cluster Helm chart. The version number has been incremented from 0.2.32 to 0.2.33 in both the Chart.yaml and README.md files. Additionally, modifications to the cluster.yaml configuration include a change in the resource specification handling for the monitoring vector component and the introduction of new configuration keys for slow query logging, enhancing the logging capabilities of the application.

Changes

File Path Change Summary
charts/greptimedb-cluster/Chart.yaml Version updated from 0.2.32 to 0.2.33.
charts/greptimedb-cluster/README.md Version badge updated from 0.2.32 to 0.2.33.
charts/greptimedb-cluster/templates/cluster.yaml Resource specification changed from .Values.monitoring.vector.resource to .Values.monitoring.vector.resources. New keys added for slow query logging: .Values.logging.slowQuery.enabled, .Values.logging.slowQuery.threshold, .Values.logging.slowQuery.sampleRatio.

Possibly related PRs

Suggested reviewers

  • daviderli614

🐰 In the meadow, hops a bunny bright,
Version numbers change, oh what a sight!
From 0.2.32 to 0.2.33,
New logs for queries, as clear as can be.
With configurations set, we’ll hop with glee! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0c909e4 and c3bf63f.

📒 Files selected for processing (3)
  • charts/greptimedb-cluster/Chart.yaml (1 hunks)
  • charts/greptimedb-cluster/README.md (1 hunks)
  • charts/greptimedb-cluster/templates/cluster.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • charts/greptimedb-cluster/Chart.yaml
  • charts/greptimedb-cluster/README.md
🔇 Additional comments (2)
charts/greptimedb-cluster/templates/cluster.yaml (2)

523-524: LGTM! Correct field name for Kubernetes resources.

The change from .Values.monitoring.vector.resource to .Values.monitoring.vector.resources aligns with the standard Kubernetes resource specification field name.


523-524: Verify the impact on existing deployments.

Since this is a field name change, existing deployments using the old field name might need migration.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zyy17 zyy17 requested a review from daviderli614 November 19, 2024 06:32
@zyy17 zyy17 changed the title fix(greptimedb-cluster): incorrect '.vector.resources' field fix(greptimedb-cluster): incorrect .vector.resources field Nov 19, 2024
@zyy17 zyy17 merged commit 608a18e into GreptimeTeam:main Nov 19, 2024
4 checks passed
@zyy17 zyy17 deleted the fix/vector-resource branch November 19, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants