refactor[cartesian]: Replace is_start_state= with is_start_block= when buiding the SDFG for DaCe
#1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_start_state has been deprecated and replaced with is_start_block in never versions of DaCe.
|
PR deprecating @egparedes would you have time for a quick review? /cc @FlorianDeconinck as mentioned today |
|
cscs-ci run |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building an SDFG for DaCe it is sometimes necessary to specify the starting point of the graph. In the past,
is_start_state=was used for this. In never versions of Dace,is_start_statehas been deprecated and replaced withis_start_block. This PR replaces the two occurrences in thecartesian/folder and removes warnings generated during test runs. It looks like thenext/folder has already been cleaned.Parent: GEOS-ESM/SMT-Nebulae#89
Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.mdfile adding the names of all the new contributors.