Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug[next]: ConstantFolding after create_global_tmps #1756

Merged
merged 6 commits into from
Nov 30, 2024
Merged

bug[next]: ConstantFolding after create_global_tmps #1756

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
716fd8d
Call ConstantFolding after create_global_tmps
SF-N Nov 28, 2024
0bca033
Move ConstantFolding into global_tmps
SF-N Nov 28, 2024
55f9cdb
Move ConstantFolding into infer_domain
SF-N Nov 28, 2024
e8d64f2
Move ConstantFolding to domain_union
SF-N Nov 29, 2024
b26e057
Merge branch 'main' into fix_ConstantFolding
SF-N Nov 29, 2024
5afd944
Update src/gt4py/next/iterator/ir_utils/domain_utils.py
SF-N Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/gt4py/next/iterator/ir_utils/domain_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from gt4py.next.iterator import ir as itir
from gt4py.next.iterator.ir_utils import ir_makers as im
from gt4py.next.iterator.transforms import trace_shifts
from gt4py.next.iterator.transforms.constant_folding import ConstantFolding


def _max_domain_sizes_by_location_type(offset_provider: Mapping[str, Any]) -> dict[str, int]:
Expand Down Expand Up @@ -168,6 +169,8 @@ def domain_union(*domains: SymbolicDomain) -> SymbolicDomain:
lambda current_expr, el_expr: im.call("maximum")(current_expr, el_expr),
[domain.ranges[dim].stop for domain in domains],
)
# constant fold expression to keep the tree small
start, stop = ConstantFolding.apply(start), ConstantFolding.apply(stop) # type: ignore[assignment] # always an itir.Expr
new_domain_ranges[dim] = SymbolicRange(start, stop)

return SymbolicDomain(domains[0].grid_type, new_domain_ranges)