Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vhier, generating file list, module list, xml file #45

Merged
merged 15 commits into from
Sep 14, 2024

Conversation

Risto97
Copy link
Contributor

@Risto97 Risto97 commented Sep 12, 2024

I liked the idea of copy_rtl_files(), however I would separate vhier as a separate target and copy_rtl_files should process xml file generated from vhier.

This function also uses Generator expressions for handling function arguments, which is the proposed way of handling function arguments

@mksoc
Copy link
Contributor

mksoc commented Sep 12, 2024

At the moment, I'm actually using a modified version of vhier to print a more useful output for us (https://github.com/HEP-SoC/verilog-perl), but if we parse the XML I believe we already have everything we need, even with the "stock" vhier.

We can look into modifying the Python script to parse the XML and change copy_rtl_files() accordingly.

@Risto97 Risto97 changed the base branch from master to develop September 12, 2024 21:59
@Risto97 Risto97 merged commit c1e6238 into develop Sep 14, 2024
1 check passed
@Risto97 Risto97 deleted the vhier branch September 14, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants