Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow add_ip short form, resolves #42 #56

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

Risto97
Copy link
Contributor

@Risto97 Risto97 commented Sep 14, 2024

This pull request implements the short signature for add_ip() function.

Now there are 3 versions:

1. Full form

add_ip(ip
    VENDOR vendor
    LIBRARY lib
    VERSION 0.0.1
)

This translates into vendor::lib::ip::0.0.1 target

In this version, it is possible to omit any of the VENDOR, LIBRARY, VERSION arguments.
A special case of full form is when all of them are omitted.

add_ip(ip)

This translates into ip target

2. Short form

In the short form the VLNV format can be passed to add_ip().
Like this:
add_ip(vendor::lib::ip::0.0.1)

In this form it is important that the full form is passed, as if one of the tokens are missing, how can we know what is VENDOR, LIBRARY, IP, VERSION

@Risto97
Copy link
Contributor Author

Risto97 commented Sep 14, 2024

resolve #42
close #42

@Risto97 Risto97 merged commit 532d078 into develop Sep 14, 2024
1 check passed
@Risto97 Risto97 deleted the add_ip_short_form branch September 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant