allow add_ip short form, resolves #42 #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the short signature for
add_ip()
function.Now there are 3 versions:
1. Full form
This translates into
vendor::lib::ip::0.0.1
targetIn this version, it is possible to omit any of the VENDOR, LIBRARY, VERSION arguments.
A special case of full form is when all of them are omitted.
This translates into
ip
target2. Short form
In the short form the VLNV format can be passed to
add_ip()
.Like this:
add_ip(vendor::lib::ip::0.0.1)
In this form it is important that the full form is passed, as if one of the tokens are missing, how can we know what is VENDOR, LIBRARY, IP, VERSION