Backend: Welcome email for New Subscribers added #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Kajol-Kumari Please review and merge it |
Kajol-Kumari
reviewed
Aug 8, 2024
|
|
||
| module.exports = async (req, res, next) => { | ||
| const transporter = nodemailer.createTransport({ | ||
| type: 'SMTP', | ||
| host: config.EMAIL_HOST, |
There was a problem hiding this comment.
can we add env.sample file and add these env variables with required values/placeholders(in case of credential)
There was a problem hiding this comment.
I think no need for env.sample file because, .env file already there with required values/placeholders.
There was a problem hiding this comment.
Then add the new env variables that got introduced in this pr there itself. It will be easier for new developers
There was a problem hiding this comment.
There is no new varaible used here and they already exists in .env file
Kajol-Kumari
added
level2
Kajol-Kumari
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: #1120
Proposed changes
For every new user, welcome email added for new subscriber added.
Types of changes
Put an
xin the boxes that applyScreenshots
Other information
Any other information that is important to this pull request