-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Welcome email for New Subscribers added #1121
Merged
Kajol-Kumari
merged 8 commits into
HITK-TECH-Community:main
from
BHS-Harish:fix-issue-1120
Aug 9, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
98e0e51
Upvote and Downvotes fixed
BHS-Harish 74914d2
Merge branch 'HITK-TECH-Community:main' into main
BHS-Harish 320d8ed
Merge branch 'HITK-TECH-Community:main' into main
BHS-Harish 7a6abd0
Merge branch 'HITK-TECH-Community:main' into main
BHS-Harish 65f9789
Merge branch 'HITK-TECH-Community:main' into main
BHS-Harish c2ca49d
Merge branch 'HITK-TECH-Community:main' into main
BHS-Harish 06c0210
Merge branch 'HITK-TECH-Community:main' into main
BHS-Harish 64f1481
Welcome email for new subscribers added
BHS-Harish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add env.sample file and add these env variables with required values/placeholders(in case of credential)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no need for
env.sample
file because,.env
file already there with required values/placeholders.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then add the new env variables that got introduced in this pr there itself. It will be easier for new developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no new varaible used here and they already exists in
.env
file