Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up web code #114

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Clean up web code #114

merged 1 commit into from
Oct 20, 2024

Conversation

ASleepyCat
Copy link
Collaborator

@ASleepyCat ASleepyCat commented Oct 20, 2024

Some preliminary clean up to better understand how Svelte's reactivity and data binding works.

Some notes:

  • Binding on class properties works
  • Reactivity with objects is a bit buggy in Svelte 4 e.g. the double update issue when loading the config. Apparently this is fixed in Svelte 5 with their new runes system

Changes:

  • Remove README.md and lib/index.ts in beef-config
  • Update eslint rule so that using _ for an unused variable doesn't show a linting error in .ts files
  • Separate various parts of web code into individual components
  • Improve colour picker code to use Svelte reactivity instead
  • Make Switch centred with label text
  • Rename disable_led to disable_leds

@ASleepyCat ASleepyCat requested a review from HWXLR8 October 20, 2024 02:09
@ASleepyCat ASleepyCat marked this pull request as draft October 20, 2024 02:43
@ASleepyCat ASleepyCat removed the request for review from HWXLR8 October 20, 2024 02:43
@ASleepyCat ASleepyCat marked this pull request as ready for review October 20, 2024 04:34
@ASleepyCat ASleepyCat requested a review from HWXLR8 October 20, 2024 04:34
@HWXLR8 HWXLR8 merged commit 3c16873 into master Oct 20, 2024
4 checks passed
@HWXLR8 HWXLR8 deleted the web-cleanup branch October 20, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants