-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HID keyboard mode #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASleepyCat
force-pushed
the
keyboard-mode
branch
from
July 21, 2024 06:52
af9f192
to
ee7b8e2
Compare
…efactoring to remove function pointers
ASleepyCat
force-pushed
the
keyboard-mode
branch
from
August 6, 2024 08:13
ae19c19
to
e6720a7
Compare
HWXLR8
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the huge effort. Code looks good. I don't want to introduce more variables into the mix, so I will defer merging until we have the TT issues sorted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86.
Keyboard mode has support for HID lighting. HID and keyboard inputs cannot be enabled at the same time, although this can be changed fairly easily if someone wants both inputs sent at the same time.
Due to button restrictions (IIDX back-compat and SDVX only having nine and seven buttons respectively), I've made input mode switching performable only on boot.
Buttons and analog mappings will need to be rebinded in spicecfg, etc. after this is merged.
Major refactoring in general:
analog_turntable
toanalog_button
since it's also used for SDVX knobsCALLBACK_USB_GetDescriptor()
, instead assign some global variablesSCREAMING_SNAKE_CASE
toPascalCase
FIXED_CONTROL_ENDPOINT_SIZE
andHID_EPSIZE
to 64INTERRUPT_CONTROL_ENDPOINT
fastled_shim.h