Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21 #346

Open
wants to merge 1 commit into
base: 1.20
Choose a base branch
from
Open

1.21 #346

wants to merge 1 commit into from

Conversation

AnsiV01
Copy link

@AnsiV01 AnsiV01 commented Jul 28, 2024

No description provided.

@AnsiV01 AnsiV01 mentioned this pull request Jul 28, 2024
@scaui0
Copy link

scaui0 commented Jul 31, 2024

Please add this!

@Azyrod
Copy link

Azyrod commented Aug 2, 2024

Hi there, this looks amazing and I was really happy to see that I can now read 1.21 source code, but the game fails to run when using the runclient gradle command, this is the error I get :
Error: LinkageError occurred while loading main class net.minecraft.client.main.Main

Could you help me figure this out ?

@AnsiV01
Copy link
Author

AnsiV01 commented Aug 3, 2024

@Azyrod Did you do all the steps one by one according to the guide? Try downloading the repository again. Btw what IDE are you using?

If IntelliJ make sure, your project uses Java 21
image
image

@Azyrod
Copy link

Azyrod commented Aug 3, 2024

@AnsiV01 My gradle was configured on Java-19, that was it, thanks !

@ModxVoldHunter
Copy link

I approve

@thewanderingtraderm
Copy link

@AnsiV01 can u update it to 1.21.1

@AnsiV01
Copy link
Author

AnsiV01 commented Aug 26, 2024

@thewanderingtraderm I will prepare a commit tomorrow

Edit:
Done in #349

@thewanderingtraderm
Copy link

@AnsiV01 where do you get the Mcp version and spi version from?

@AnsiV01
Copy link
Author

AnsiV01 commented Aug 27, 2024

@thewanderingtraderm
MCP: https://files.minecraftforge.net/net/minecraftforge/forge/index_1.21.1.html
SPI: https://files.minecraftforge.net/net/minecraftforge/forgespi/index.html

Here is one small problem with MCP, because in order to know the ‘mcp_version’ you have to download mdk, run the client and find in the logs what version is being used (at least I do, it's possible that there is a better way to do it, but at the moment I don't know it)

@sheduxdev
Copy link

Hey @AnsiV01 can you push 1.21 optifine source too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants