Update the WebContent instance when setting an UA override #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…67-benchmark-118.0.5993.122-r1 to 118-5993.86-1698061367-benchmark-118.0.5993.124-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I48cea1c1e9d13d4b9d27739ad7562f22c4b608d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4983804 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1456} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Change-Id: Iaa6a7b86fff12f74d0ee620bdf084fdf62308e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4983186 Auto-Submit: Ben Mason <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1457} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…-118.0.5993.123-r1 to 118-5993.86-1698061367-benchmark-118.0.5993.124-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I6840431c4b5954682d8a45295e0a20f0f2c02d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984314 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1458} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Automatic update for 2023-10-27 UTC Change-Id: Ic81b4985f9808f632235230245ec9441ecfdf41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4982357 Bot-Commit: PKI Metadata Updates Bot <[email protected]> Commit-Queue: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1459} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…ark-118.0.5993.123-r1 to 118-5993.86-1698055946-benchmark-118.0.5993.124-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I463515ba8a65712cd646c0abab497cc98e4712be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984787 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1460} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/732e44cd8932..4a132729e0eb Generated by: go/bbid/8766059308529604353 Change-Id: I839e413143feb0ac3ea0a80750fbc6b76d739cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984526 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{#1461} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Change-Id: I7a6cbca772e641b14da904cee245c78b1e68633c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986481 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{#1462} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
https://crrev.com/c/4948973 is blocked because this test keeps failing on the android-nougat-x86-rel tryjob As Nougat has been deprecated since M119, it makes more sense to disable the test on M118 branch. Bug: 1488458 Change-Id: I863e367dab69504703e8eb961ca6b215e8536c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4985466 Auto-Submit: Haiyang Pan <[email protected]> Reviewed-by: Tomasz Wiszkowski <[email protected]> Commit-Queue: Tomasz Wiszkowski <[email protected]> Owners-Override: Tomasz Wiszkowski <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1463} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
This cl only affect Lacros or Skylab on-device config builders like lacros-amd64-generic-chrome-skylab or "ChromeOS FYI Release Skylab (kevin)". This cl will certainly NOT affect linux-lacros builders (linux-lacros-tester-rel, linux-lacros-rel, etc) or any other platforms. This CL will update cros image version for skylab tests. CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Requires-Testing: True Change-Id: I7a869dacf18024ba7e7cc4a220912ede7a7739b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986482 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1464} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I778e6b2b273ff58f869c8884ef1e5aeed0aae4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4985599 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1465} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Uploaded by https://ci.chromium.org/b/8766037339069911441 Change-Id: I12d1a6bf15aad9f0204cc442bbd67585b450e363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987186 Commit-Queue: ChromeOS bot <[email protected]> Bot-Commit: ChromeOS bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1466} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…118.0.5993.124-r1 to 118-5993.86-1698062570-benchmark-118.0.5993.125-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I19efdff78a39e6c537ca69922443f0a56cf22e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987381 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1467} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Automatic update for 2023-10-28 UTC Change-Id: I94eea512e39f32a764dba561c20d0e4fc1325a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987002 Bot-Commit: PKI Metadata Updates Bot <[email protected]> Commit-Queue: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1468} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Change-Id: I03f13a0aaf01dd47682bdc051f58c7cdad047021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986122 Auto-Submit: Ben Mason <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1469} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…ark-118.0.5993.124-r1 to 118-5993.86-1698055946-benchmark-118.0.5993.125-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I43f738e75d99148fa6a1bf2ea299a9acc8f26ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987250 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1470} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…-118.0.5993.124-r1 to 118-5993.86-1698061367-benchmark-118.0.5993.125-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ie071e328626c5547e0d389b78564bac93bbdffad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986927 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1471} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Change-Id: I50aec01176553c2ed282b079358d22107d6121bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986763 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{#1472} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
This CL updates the ash version ['120.0.6094.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Bug: None Change-Id: I394d754c2ceefcabcd629f46c85a4177b370675c Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987406 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1473} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Iedea29f28b76c00e5ac01d901825fed0d954e010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986379 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1474} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Uploaded by https://ci.chromium.org/b/8765946545644632657 Change-Id: I2bbf53a1b123fa46846be729a295cd794a875336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987586 Commit-Queue: ChromeOS bot <[email protected]> Bot-Commit: ChromeOS bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1475} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…67-benchmark-118.0.5993.124-r1 to 118-5993.86-1698061367-benchmark-118.0.5993.125-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ie303cf9ef20ab21eddbbf061b77d2ebfcdfdbfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988092 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1476} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Change-Id: I8a8f04923df60972282bb127adcba0f1967f0977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987643 Auto-Submit: Ben Mason <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1477} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Automatic update for 2023-10-29 UTC Change-Id: I55e306c33138e68178a8bf16da314b6da279da45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988242 Commit-Queue: PKI Metadata Updates Bot <[email protected]> Bot-Commit: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1478} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…118.0.5993.125-r1 to 118-5993.86-1698062570-benchmark-118.0.5993.126-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I3031697313bfef4b84c2b87c91e003e395d1a285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988097 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1479} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Automatic update for 2023-10-29 UTC Change-Id: Iffd769051ac80c6c9d7685e076cc0df5a34b1443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988362 Commit-Queue: PKI Metadata Updates Bot <[email protected]> Bot-Commit: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1480} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…ark-118.0.5993.125-r1 to 118-5993.86-1698055946-benchmark-118.0.5993.126-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I339542ad9a06542692ace1fc03f4973acda32203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987731 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1481} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…-118.0.5993.125-r1 to 118-5993.86-1698061367-benchmark-118.0.5993.126-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I89a8f5fea18968b1b38dd4903154276164192b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988192 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1482} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
Change-Id: I5f0a5c7fb6282d95b0173e31271e0ee8957d70c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986764 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{#1483} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
This CL updates the ash version ['120.0.6096.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC [email protected]. [email protected] Bug: None Change-Id: I3683944f1d0a24b667bfef35241e1d7e5c322f90 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4986205 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1484} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
…-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-stable Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Stable Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I2ea19fb39d55936ebec5bd24fd474e5b08e0bf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988778 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{#1485} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
The stuck flow issue is where new frame information is not gotten when SubmitFrameMissing is notified from the renderer. This patch adds a pending callback to prevent the sequence from stuck. Co-authored-by: Miyoung Shin <[email protected]>
The white flash issue is caused by we can't draw anything to the texture, but wolvic tries to draw the texture to the screen. This patch increase the frame index only when the frame is submitted. Co-authored-by: Miyoung Shin <[email protected]>
This patch fixes the issue that does not reflect the frame skip of the web page's intention by using vsync of wolvic. If the frame skip is requred, then `dropFrame` will be true, and Chromium will wait a next tick of vsync in wolvic side, and then will get a new frame's information.
Allow browser to mark navigation entries as 'skippable' so that they are not used when performing back/forward navigation. This allows us to fix navigation issues caused by YouTube redirects to desktop app. This change also fixes a crash which happened when rapidly clicking back/forward button multiple times by ensuring that any navigation doesn't go out of bounds.
A legacy rationale is behind the usage of WebVr in the manager APIs. Some other APIs in Chromium were using the name of the old VR standard for the Web, but there is really no reason to use that instead of WebXR which is the one that arrived to stay.
Instead of passing two integer arguments we can use a gfx::Size which already encapsulates an integer size in a single attribute. On the one hand it's more meaningful as it is now obvious that both sizes are related, and on the other hand it allows us to use the gfx::Size which is returned directly by other APIs without having to decompose it in its two components.
It used to receive a boolean as single argument. The problem of using booleans in public APIs is that the caller does not really know what it does really mean, forcing developers to check the signature an implementation of the API. By using an enumerated type the callsites become self-explanatory.
This patch implements to support a HTTP Authentication's prompt that asks the user for a username and password when 401 or 407 status is received as an HTTP response.
This patch implements the file selection that uses `<input type=file>`. The selected file should be an absolute file path since the policy checking if the file can be read only allows the absolute file path.
Initially testonly flag was required by several content_shell related dependencies. Since then we reduced our dependency on content_shell heavily and this flag is no longer required. This patch removes all remaining test dependencies and gets rid of the testonly flag.
When enabling minification in Wolvic, the Wolvic classes that are part of the Chromium tree are removed. This breaks many use cases, for example, WebXR does not work at all. By adding a keep rule for all Wolvic classes we manage to get a fully working minified packages.
Update WolvicPermissionManager logic to prevent dialogs for identical permission requests from being started twice. This can happen when an Android activity is restarted due to a denied Android permission. In that case we want to rely on the initial user response instead of starting another user dialog.
Add a new parameter to PermissionManagerBridge.onPermissionRequest called "androidPermissionTypes" that contains names of Android permissions that must be requested for the corresponding content permission specified on "permissionTypes".
This CL adds the delegation in SelectionPopupController to expose the interface called by native to wolvic.
The call to GetJavaDelegate could return jobject whose obj() is null. That's why all the delegates in chromium code have a is_null() check after the aforementioned call. We instead had a DCHECK because we thought it was not possible to get a null object there but the truth is that sometimes we do and in those cases it was causing a crash on release builds. It's still unclear why it happens but we should avoid those crashes. When that obj() is null then we bail out and the navigation does not succeed. We haven't figured out yet which cases trigger those conditions too.
This is a refactoring with no functional changes. We move logic that was implemented on the Wolvic side before to the backend side: - Requesting android permissions that match the corresponding content permissions. - Combining results of content and android permission requests to return them to the Content API. This is a precursor for microphone and camera permissions support, since it requires a third type of permissions: media permissions.
Using enum is not recommended on Android: https://medium.com/android-news/android-performance-avoid-using-enum-on-android-326be0794dc3 Also, we'll be adding more enums for media permissions support and it'll be better to have them as integers to keep the code more consistent with wolvic.
Extend functionality of WolvicPermissionManager to also support media permissions such as microphone and camera access. Media permissions are requested differently from other content permissions, the entry point for them is the WebContentsDelegate implementation. In this solution, we forward such calls from WolvicWebContentsDelegate to WolvicPermissionManager. The permissions manager first requests any required content and android permissions and only then requests media permissions via the PermissionManagerBridge class.
This patch change to own Wolvic.pak for resources instead of content_shell.pak with repack resources pack to give a flexiblity including resources in out of //content.
- WolvicPasswordManagerClient for Login save - WolvicPasswordStorageBackend for Login DB - WolvicAutofillClient for autofill username/password - WolvicSignClient is dummy class to avoid crash issue - Changed components/autofill not to show suggestions of login whenever text field is changed. - WolvicRenderFrameObserver for binding Autofill Agent's mojo
svillar
requested changes
Apr 9, 2024
wolvic/browser/session_settings.cc
Outdated
| content::NavigationController& controller = web_contents()->GetController(); | ||
| for (int i = 0; i < controller.GetEntryCount(); ++i) | ||
| controller.GetEntryAtIndex(i)->SetIsOverridingUserAgent(true); | ||
| } |
There was a problem hiding this comment.
Not sure I get this. Are we backpropagating the UA override change to previous navigation entries? That does not seem correct....
There was a problem hiding this comment.
The idea is to update the current navigation entries. Again, this logic is similar to what AwSettings is doing, although in that case, they do that in the WebContentsChanged event from the observer. Perhaps we should do the same.
zakharvoit
approved these changes
Apr 11, 2024
svillar
reviewed
Apr 11, 2024
wolvic/browser/session_settings.cc
Outdated
| // assignes nullptr to the web_contents_ attribute. | ||
| void SessionSettings::UpdateEverything() { | ||
| UpdateUserAgent(); | ||
| } |
There was a problem hiding this comment.
Why do we need an additional method?
There was a problem hiding this comment.
Just a template for future settings that we may need to update when the rvh changes. Anyway, I just wanted to get early feedback on the general approach, whether we want / need to add this logic to the SessionSettings class.
zakharvoit
force-pushed
the
wolvic_experimental
branch
from
fe68180
to
6969308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are storing the UA override in the WolvicContentBrowserClient's settings, but we need also to propagate this data to the WebContent instance as well, so that the NavigationRequest is aware.