Revert "Synthesize FCP for cached pages" #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aae8014. This workaround was added after the update to Gecko 121. The issues with first contentful paint are not here anymore so we can remove it and avoid synthesizing FCP events at the wrong time which were causing issues when taking screenshots of the web contents. When those generated FCPs were issued, the Gecko compositor was not in a ready state to generate a screenshot and thus an exception was generated. Gecko was not handling it properly so it was affecting subsequent JNI calls causing crashes and hangs in Gecko. Fixes #1638
javifernandez
approved these changes
Nov 20, 2024
|
Hmm I've tried it with slow connections and the issue that the original patch was fixing reappeared, i.e., starting Wolvic sometimes results in an empty web view. |
The FCP event is not emitted by GeckoView if the page is loaded from the cache (either HTTP or back/forward). As a result many things are not properly set up in Wolvic, like the current active session, resulting in many cases in web contents not visible on app start. In those cases we should generate and emit it to get things working.
javifernandez
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit aae8014.
This workaround was added after the update to Gecko 121. The issues with first contentful paint are not here anymore so we can remove it and avoid synthesizing FCP events at the wrong time which were causing issues when taking screenshots of the web contents.
When those generated FCPs were issued, the Gecko compositor was not in a ready state to generate a screenshot and thus an exception was generated. Gecko was not handling it properly so it was affecting subsequent JNI calls causing crashes and hangs in Gecko.
Fixes #1638