Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Synthesize FCP for cached pages" #1641

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Commits on Nov 20, 2024

  1. Revert "Synthesize FCP for cached pages"

    This reverts commit aae8014.
    
    This workaround was added after the update to Gecko 121. The issues
    with first contentful paint are not here anymore so we can remove
    it and avoid synthesizing FCP events at the wrong time which were
    causing issues when taking screenshots of the web contents.
    
    When those generated FCPs were issued, the Gecko compositor was
    not in a ready state to generate a screenshot and thus an exception
    was generated. Gecko was not handling it properly so it was
    affecting subsequent JNI calls causing crashes and hangs in Gecko.
    
    Fixes #1638
    svillar committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b259d74 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Emit onFirstContentfulPaint paint for cached pages

    The FCP event is not emitted by GeckoView if the page is loaded from the cache
    (either HTTP or back/forward). As a result many things are not properly set up
    in Wolvic, like the current active session, resulting in many cases in web
    contents not visible on app start.
    
    In those cases we should generate and emit it to get things working.
    svillar committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b2dcf69 View commit details
    Browse the repository at this point in the history